Re: [Qemu-devel] [PATCH 2/2] Header cleanups- Tabs replaced with spaces

[Philippe Mathieu-Daudé]

On 4/1/19 11:39 AM, Daniel P. Berrangé wrote:
> On Mon, Apr 01, 2019 at 01:56:55PM +0530, Aruna Jayasena wrote:
>> Declarations were moved out of qemu-common.h for functions declared in 
>> utils/ files.
>> This task was under https://wiki.qemu.org/Contribute/BiteSizedTasks
>>
>> Signed-off-by: Aruna Jayasena <address@hidden>
>>
>> ---
>>  include/qemu/id.h       | 4 ++--
>>  include/qemu/readline.h | 2 +-
>>  2 files changed, 3 insertions(+), 3 deletions(-)
>>
>> diff --git a/include/qemu/id.h b/include/qemu/id.h
>> index 3a651fb9d2..f3451344e2 100644
>> --- a/include/qemu/id.h
>> +++ b/include/qemu/id.h
>> @@ -1,8 +1,8 @@
>>  #ifndef QEMU_ID_H
>>  #define QEMU_ID_H
>>  
>> -#define qemu_isalnum(c)             isalnum((unsigned char)(c))
>> -#define qemu_isalpha(c)             isalpha((unsigned char)(c))
>> +#define qemu_isalnum(c)    isalnum((unsigned char)(c))
>> +#define qemu_isalpha(c)    isalpha((unsigned char)(c))
>>  
>>  typedef enum IdSubSystems {
>>      ID_QDEV,
>> diff --git a/include/qemu/readline.h b/include/qemu/readline.h
>> index 4cbf7ead5a..67859a3028 100644
>> --- a/include/qemu/readline.h
>> +++ b/include/qemu/readline.h
>> @@ -1,7 +1,7 @@
>>  #ifndef READLINE_H
>>  #define READLINE_H
>>  
>> -#define qemu_isspace(c)             isspace((unsigned char)(c))
>> +#define qemu_isspace(c)    isspace((unsigned char)(c))
>>  
>>  #define READLINE_CMD_BUF_SIZE 4095
>>  #define READLINE_MAX_CMDS 64
> 
> This should just be fixed when moving the macros out of qemu-common.h

Hmm I did a series following your suggestion of using g_ascii_*()
instead of qemu_* helpers, and plan to send it for 4.1. Eventually
Aruna's work can go on top...

> 
> Regards,
> Daniel
>