Re: [Qemu-devel] [PATCH 0/3] util/readline: coding style clean-up with regards to TABs and spaces

[no-reply]

Patchew URL: https://patchew.org/QEMU/address@hidden/



Hi,

This series seems to have some coding style problems. See output below for
more information:

Message-id: address@hidden
Subject: [Qemu-devel] [PATCH 0/3] util/readline: coding style clean-up with 
regards to TABs and spaces
Type: series

=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
 t [tag update]            patchew/address@hidden -> patchew/address@hidden
 * [new tag]               patchew/address@hidden -> patchew/address@hidden
Switched to a new branch 'test'
e3270a2500 util: readline: replace tab indent by four spaces to fix checkpatch 
errors
5a6b6bf31d util: add required space to fix checkpatch errors
7a6013dc34 util: add a space before an open parenthesis to fix checkpatch errors

=== OUTPUT BEGIN ===
1/3 Checking commit 7a6013dc34e0 (util: add a space before an open parenthesis 
to fix checkpatch errors)
ERROR: braces {} are necessary for all arms of this statement
#30: FILE: util/readline.c:57:
+            for (i = 0; i < len; i++)
[...]

ERROR: space required after that ';' (ctx:VxV)
#39: FILE: util/readline.c:70:
+            for (i = 0;i < delta; i++) {
                       ^

ERROR: space required after that ';' (ctx:VxV)
#45: FILE: util/readline.c:75:
+            for (i = 0;i < delta; i++) {
                       ^

ERROR: spaces required around that '=' (ctx:VxV)
#71: FILE: util/readline.c:323:
+                for (j=0; j<max_prefix; j++) {
                       ^

ERROR: spaces required around that '<' (ctx:VxV)
#71: FILE: util/readline.c:323:
+                for (j=0; j<max_prefix; j++) {
                            ^

total: 5 errors, 0 warnings, 96 lines checked

Patch 1/3 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

2/3 Checking commit 5a6b6bf31d70 (util: add required space to fix checkpatch 
errors)
3/3 Checking commit e3270a250091 (util: readline: replace tab indent by four 
spaces to fix checkpatch errors)
ERROR: braces {} are necessary for all arms of this statement
#32: FILE: util/readline.c:186:
+            if (rs->history[idx] == NULL)
[...]

ERROR: braces {} are necessary for all arms of this statement
#101: FILE: util/readline.c:233:
+        if (hist_entry == NULL)
[...]

ERROR: braces {} are necessary for all arms of this statement
#111: FILE: util/readline.c:243:
+                if (rs->history[idx] == NULL)
[...]

total: 3 errors, 0 warnings, 161 lines checked

Patch 3/3 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

=== OUTPUT END ===

Test command exited with code: 1


The full log is available at
http://patchew.org/logs/address@hidden/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to address@hidden