Re: [Qemu-devel] [Qemu-ppc] [PULL 4/8] target/ppc: Improve comment of bcctr used for spectre v2 mitigation

[David Gibson]

On Fri, Mar 29, 2019 at 10:37:08AM +0100, BALATON Zoltan wrote:
> On Fri, 29 Mar 2019, David Gibson wrote:
> > From: Greg Kurz <address@hidden>
> > 
> > Signed-off-by: Greg Kurz <address@hidden>
> > Message-Id: <address@hidden>
> > Signed-off-by: David Gibson <address@hidden>
> > ---
> > target/ppc/translate.c | 10 +++++++++-
> > 1 file changed, 9 insertions(+), 1 deletion(-)
> > 
> > diff --git a/target/ppc/translate.c b/target/ppc/translate.c
> > index 576210d901..badc1ae1a3 100644
> > --- a/target/ppc/translate.c
> > +++ b/target/ppc/translate.c
> > @@ -3753,7 +3753,15 @@ static void gen_bcond(DisasContext *ctx, int type)
> >              * All ISAs up to v3 describe this form of bcctr as invalid but
> >              * some processors, ie. 64-bit server processors compliant with
> >              * arch 2.x, do implement a "test and decrement" logic instead,
> > -             * as described in their respective UMs.
> > +             * as described in their respective UMs. This logic involves 
> > CTR
> 
> Shouldn't this have been squashed in patch 2 where this comment is added
> instead of modifying it right away?

Drat, I didn't spot that.  It's not ideal but I don't think it's worth
respinning the pull request for.

-- 
David Gibson                    | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au  | minimalist, thank you.  NOT _the_ _other_
                                | _way_ _around_!
http://www.ozlabs.org/~dgibson

signature.asc
Description: PGP signature