qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH 1/2] qmp: Add query-qemu-features


From: Eric Blake
Subject: Re: [Qemu-devel] [PATCH 1/2] qmp: Add query-qemu-features
Date: Thu, 28 Mar 2019 13:43:53 -0500
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.6.0

On 3/28/19 1:28 PM, Kevin Wolf wrote:
> From: Stefan Hajnoczi <address@hidden>
> 
> QMP clients can usually detect the presence of features via schema
> introspection.  There are rare features that do not involve schema
> changes and are therefore impossible to detect with schema
> introspection.
> 
> This patch adds the query-qemu-features command. It returns a struct
> containing booleans for each feature that QEMU can support.
> 
> The decision to make this a command rather than something statically
> defined in the schema is intentional. It allows QEMU to decide which
> features are available at runtime, if necessary.
> 
> Signed-off-by: Stefan Hajnoczi <address@hidden>
> Signed-off-by: Kevin Wolf <address@hidden>
> ---
>  qapi/misc.json | 23 +++++++++++++++++++++++
>  qmp.c          | 10 ++++++++++
>  2 files changed, 33 insertions(+)

Addition of a new QMP command, but justifiable for 4.0 because of the
nature of the bug which it will enable us to fix.  Still, let's get it
into -rc2 rather than delaying the release...

Reviewed-by: Eric Blake <address@hidden>

-- 
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3226
Virtualization:  qemu.org | libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature


reply via email to

[Prev in Thread] Current Thread [Next in Thread]