Re: [Qemu-devel] [PATCH] vl: Fix to create migration object before block backends again

[Markus Armbruster]

Anthony PERARD <address@hidden> writes:

> On Tue, Mar 26, 2019 at 06:48:54PM +0100, Markus Armbruster wrote:
>> Known dependencies:
>> 
>> * migration object_init() must run before configure_blockdev(), so block
>>   backends can register migration blockers
>> 
>> * configure_blockdev() must run before machine_set_property(), so
>>   machine properties can refer to block backends.
>> 
>> * configure_accelerator() must run after machine creation, because it
>>   needs a machine
>> 
>> * configure_accelerator() must run before migration_object_init(), so
>>   migration_object_init() can see accelerator compat properties.
>> 
>> We're currently violating the last one, because weren't aware of it.  To
>> fix that, rejigger some more: move configure_accelerator() before
>> migration_object_init() (with a suitable comment), then see what else
>> breaks.  Could you try the appended patch and report whether it fixes
>> your problem?
>
> Yes, that patch works and doesn't break anything else with Xen.

Thanks!  I posted this fix together with another one as "[PATCH 0/2]
Compat props bug fixes".  I fogot to add your Tested-by, sorry.