[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2] target: mips: remove a space before open par
From: |
Aleksandar Markovic |
Subject: |
Re: [Qemu-devel] [PATCH v2] target: mips: remove a space before open parenthesis to fix checkpatch error |
Date: |
Wed, 27 Mar 2019 14:18:26 +0000 |
Excellent, Jules! I just want to suggest few minor improvements.
> From: Jules Irenge <address@hidden>
> Subject: [PATCH v2] target: mips: remove a space before open parenthesis to
> fix checkpatch error
>
"target: mips:" should be "target/mips:". That is our convention for
all changes under target/mips directory (a similar rule is valid for
other target architectures too).
> Remove a space before bracket to fix checkpatch error
> "ERROR: space prohibited between function name and open parenthesis".
>
Just change "error" to "errors" and, to clarify the scope of the patch,
add at the and of the sentence "within the file target/mips/cp0_timer.c" .
Regards,
Aleksandar
> Signed-off-by: Jules Irenge <address@hidden>
> ---
> This v2 version includes fix of all error of space on function and
> paranthesis in this file
> target/mips/cp0_timer.c | 12 ++++++------
> 1 file changed, 6 insertions(+), 6 deletions(-)
>
> diff --git a/target/mips/cp0_timer.c b/target/mips/cp0_timer.c
> index f4716395df..742f4b2890 100644
> --- a/target/mips/cp0_timer.c
> +++ b/target/mips/cp0_timer.c
> @@ -29,7 +29,7 @@
> #define TIMER_PERIOD 10 /* 10 ns period for 100 Mhz frequency */
>
> /* XXX: do not use a global */
> -uint32_t cpu_mips_get_random (CPUMIPSState *env)
> +uint32_t cpu_mips_get_random(CPUMIPSState *env)
> {
> static uint32_t seed = 1;
> static uint32_t prev_idx = 0;
> @@ -73,7 +73,7 @@ static void cpu_mips_timer_expire(CPUMIPSState *env)
> qemu_irq_raise(env->irq[(env->CP0_IntCtl >> CP0IntCtl_IPTI) & 0x7]);
> }
>
> -uint32_t cpu_mips_get_count (CPUMIPSState *env)
> +uint32_t cpu_mips_get_count(CPUMIPSState *env)
> {
> if (env->CP0_Cause & (1 << CP0Ca_DC)) {
> return env->CP0_Count;
> @@ -91,7 +91,7 @@ uint32_t cpu_mips_get_count (CPUMIPSState *env)
> }
> }
>
> -void cpu_mips_store_count (CPUMIPSState *env, uint32_t count)
> +void cpu_mips_store_count(CPUMIPSState *env, uint32_t count)
> {
> /*
> * This gets called from cpu_state_reset(), potentially before timer
> init.
> @@ -109,7 +109,7 @@ void cpu_mips_store_count (CPUMIPSState *env, uint32_t
> count)
> }
> }
>
> -void cpu_mips_store_compare (CPUMIPSState *env, uint32_t value)
> +void cpu_mips_store_compare(CPUMIPSState *env, uint32_t value)
> {
> env->CP0_Compare = value;
> if (!(env->CP0_Cause & (1 << CP0Ca_DC)))
> @@ -131,7 +131,7 @@ void cpu_mips_stop_count(CPUMIPSState *env)
> TIMER_PERIOD);
> }
>
> -static void mips_timer_cb (void *opaque)
> +static void mips_timer_cb(void *opaque)
> {
> CPUMIPSState *env;
>
> @@ -151,7 +151,7 @@ static void mips_timer_cb (void *opaque)
> env->CP0_Count--;
> }
>
> -void cpu_mips_clock_init (MIPSCPU *cpu)
> +void cpu_mips_clock_init(MIPSCPU *cpu)
> {
> CPUMIPSState *env = &cpu->env;
>
> --
> 2.20.1
>