Re: [Qemu-devel] [PATCH v2 3/6] Categorize devices: DIMM

[Philippe Mathieu-Daudé]

Le mer. 27 mars 2019 13:32, Ernest Esene <address@hidden> a écrit :

> Set category and describe DIMM devices
>
> Signed-off-by: Ernest Esene <address@hidden>
>
> ---
> v2:
>   * split into separate patches
> ---
>  hw/mem/nvdimm.c  | 1 +
>  hw/mem/pc-dimm.c | 1 +
>  2 files changed, 2 insertions(+)
>
> diff --git a/hw/mem/nvdimm.c b/hw/mem/nvdimm.c
> index bf2adf5e16..a334dbe1f5 100644
> --- a/hw/mem/nvdimm.c
> +++ b/hw/mem/nvdimm.c
> @@ -200,6 +200,7 @@ static void nvdimm_class_init(ObjectClass *oc, void
> *data)
>      ddc->realize = nvdimm_realize;
>      mdc->get_memory_region = nvdimm_md_get_memory_region;
>      dc->props = nvdimm_properties;
> +    dc->desc = "NVDIMM memory module";
>
>      nvc->read_label_data = nvdimm_read_label_data;
>      nvc->write_label_data = nvdimm_write_label_data;
> diff --git a/hw/mem/pc-dimm.c b/hw/mem/pc-dimm.c
> index 152400b1fc..19b9c0f406 100644
> --- a/hw/mem/pc-dimm.c
> +++ b/hw/mem/pc-dimm.c
> @@ -259,6 +259,7 @@ static void pc_dimm_class_init(ObjectClass *oc, void
> *data)
>      dc->unrealize = pc_dimm_unrealize;
>      dc->props = pc_dimm_properties;
>      dc->desc = "DIMM memory module";
> +    set_bit(DEVICE_CATEGORY_MISC, dc->categories);
>

Hmm should we add a MEMORY category?


>      ddc->get_vmstate_memory_region = pc_dimm_get_memory_region;
>
> --
> 2.14.2
>
>