Re: [Qemu-devel] [PATCH v2 1/6] Categorize devices: IPMI

[Philippe Mathieu-Daudé]

Le mer. 27 mars 2019 13:23, Ernest Esene <address@hidden> a écrit :

> Set category and describe IPMI devices
>
> Signed-off-by: Ernest Esene <address@hidden>
>
> ---
> v2:
>   * split into different patches
>   * change category and description for management controllers
> ---
>  hw/ipmi/ipmi_bmc_extern.c | 2 ++
>  hw/ipmi/ipmi_bmc_sim.c    | 2 ++
>  hw/ipmi/isa_ipmi_bt.c     | 2 ++
>  hw/ipmi/isa_ipmi_kcs.c    | 2 ++
>  4 files changed, 8 insertions(+)
>
> diff --git a/hw/ipmi/ipmi_bmc_extern.c b/hw/ipmi/ipmi_bmc_extern.c
> index bf0b7ee0f5..6d0c1f0734 100644
> --- a/hw/ipmi/ipmi_bmc_extern.c
> +++ b/hw/ipmi/ipmi_bmc_extern.c
> @@ -526,6 +526,8 @@ static void ipmi_bmc_extern_class_init(ObjectClass
> *oc, void *data)
>      dc->hotpluggable = false;
>      dc->realize = ipmi_bmc_extern_realize;
>      dc->props = ipmi_bmc_extern_properties;
> +    set_bit(DEVICE_CATEGORY_MISC, dc->categories);
> +    dc->desc = "IPMI External Baseboard management controller";
>  }
>
>  static const TypeInfo ipmi_bmc_extern_type = {
> diff --git a/hw/ipmi/ipmi_bmc_sim.c b/hw/ipmi/ipmi_bmc_sim.c
> index 9b509f829b..5d2438234b 100644
> --- a/hw/ipmi/ipmi_bmc_sim.c
> +++ b/hw/ipmi/ipmi_bmc_sim.c
> @@ -2016,6 +2016,8 @@ static void ipmi_sim_class_init(ObjectClass *oc,
> void *data)
>      dc->realize = ipmi_sim_realize;
>      dc->props = ipmi_sim_properties;
>      bk->handle_command = ipmi_sim_handle_command;
> +    set_bit(DEVICE_CATEGORY_MISC, dc->categories);
> +    dc->desc = "IPMI Simulated Baseboard management controller";
>  }
>
>  static const TypeInfo ipmi_sim_type = {
> diff --git a/hw/ipmi/isa_ipmi_bt.c b/hw/ipmi/isa_ipmi_bt.c
> index 8bbb1fa785..9ca3402e98 100644
> --- a/hw/ipmi/isa_ipmi_bt.c
> +++ b/hw/ipmi/isa_ipmi_bt.c
> @@ -541,6 +541,8 @@ static void isa_ipmi_bt_class_init(ObjectClass *oc,
> void *data)
>
>      dc->realize = isa_ipmi_bt_realize;
>      dc->props = ipmi_isa_properties;
> +    set_bit(DEVICE_CATEGORY_BRIDGE, dc->categories);
> +    dc->desc = "ISA IPMI BT System Interface";
>
>      iic->get_backend_data = isa_ipmi_bt_get_backend_data;
>      ipmi_bt_class_init(iic);
> diff --git a/hw/ipmi/isa_ipmi_kcs.c b/hw/ipmi/isa_ipmi_kcs.c
> index a79431554a..818d59d17b 100644
> --- a/hw/ipmi/isa_ipmi_kcs.c
> +++ b/hw/ipmi/isa_ipmi_kcs.c
> @@ -524,6 +524,8 @@ static void isa_ipmi_kcs_class_init(ObjectClass *oc,
> void *data)
>
>      dc->realize = ipmi_isa_realize;
>      dc->props = ipmi_isa_properties;
> +    set_bit(DEVICE_CATEGORY_BRIDGE, dc->categories);
> +    dc->desc = "ISA IPMI KCS System Interface";
>
>      iic->get_backend_data = isa_ipmi_kcs_get_backend_data;
>      ipmi_kcs_class_init(iic);
> --
> 2.14.2
>

Reviewed-by: Philippe Mathieu-Daudé <address@hidden>

>