Re: [Qemu-devel] [PATCH] target: mips: remove a space before open parenthesis to fix checkpatch error

[Aleksandar Markovic]

> From: Jules Irenge <address@hidden>
> Subject: [PATCH] target: mips: remove a space before open parenthesis to fix 
> checkpatch error
> 
> Remove a space before bracket  to fix checkpatch error
> "ERROR: space prohibited between function name and open parenthesis".
> 
> Signed-off-by: Jules Irenge <address@hidden>
> ---
>  target/mips/cp0_timer.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 

Hello, Jules!

I truly appreciate your sending this patch!

It looks to me that fixing other similar cases in the same file
would be appropriate to include in this patch. From the output of
"scripts/checkpatch.pl -f target/mips/cp0_timer.c":

ERROR: space prohibited between function name and open parenthesis '('
#76: FILE: target/mips/cp0_timer.c:76:
+uint32_t cpu_mips_get_count (CPUMIPSState *env)

ERROR: space prohibited between function name and open parenthesis '('
#94: FILE: target/mips/cp0_timer.c:94:
+void cpu_mips_store_count (CPUMIPSState *env, uint32_t count)

ERROR: space prohibited between function name and open parenthesis '('
#112: FILE: target/mips/cp0_timer.c:112:
+void cpu_mips_store_compare (CPUMIPSState *env, uint32_t value)

ERROR: space prohibited between function name and open parenthesis '('
#134: FILE: target/mips/cp0_timer.c:134:
+static void mips_timer_cb (void *opaque)

ERROR: space prohibited between function name and open parenthesis '('
#154: FILE: target/mips/cp0_timer.c:154:
+void cpu_mips_clock_init (MIPSCPU *cpu)

Could you perhaps send a v2 of this patch that will cover these
additional five cases?

Sincerely,
Aleksandar


> diff --git a/target/mips/cp0_timer.c b/target/mips/cp0_timer.c
> index f4716395df..96a8cb68ef 100644
> --- a/target/mips/cp0_timer.c
> +++ b/target/mips/cp0_timer.c
> @@ -29,7 +29,7 @@
>  #define TIMER_PERIOD 10 /* 10 ns period for 100 Mhz frequency */
> 
>  /* XXX: do not use a global */
> -uint32_t cpu_mips_get_random (CPUMIPSState *env)
> +uint32_t cpu_mips_get_random(CPUMIPSState *env)
>  {
>      static uint32_t seed = 1;
>      static uint32_t prev_idx = 0;
> --
> 2.20.1
>