Re: [Qemu-devel] [PATCH] intel_iommu: Correct caching-mode error message

[Philippe Mathieu-Daudé]

Le mer. 27 mars 2019 00:06, Alex Williamson <address@hidden> a
écrit :

> If we try to use the intel-iommu device with vfio-pci devices without
> caching mode enabled, we're told:
>
>   qemu-system-x86_64: We need to set caching-mode=1 for intel-iommu to
> enable
>   device assignment with IOMMU protection.
>
> But to enable caching mode, the option is actually "caching-mode=on".
>
> Signed-off-by: Alex Williamson <address@hidden>
> ---
>  hw/i386/intel_iommu.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/hw/i386/intel_iommu.c b/hw/i386/intel_iommu.c
> index b90de6c66461..b62badd4f08d 100644
> --- a/hw/i386/intel_iommu.c
> +++ b/hw/i386/intel_iommu.c
> @@ -2919,7 +2919,7 @@ static void
> vtd_iommu_notify_flag_changed(IOMMUMemoryRegion *iommu,
>      IntelIOMMUState *s = vtd_as->iommu_state;
>
>      if (!s->caching_mode && new & IOMMU_NOTIFIER_MAP) {
> -        error_report("We need to set caching-mode=1 for intel-iommu to
> enable "
> +        error_report("We need to set caching-mode=on for intel-iommu to
> enable "
>                       "device assignment with IOMMU protection.");
>          exit(1);
>      }
>

Reviewed-by: Philippe Mathieu-Daudé <address@hidden>

>