Re: [Qemu-devel] [PULL 14/15] Migration/colo.c: Make user obtain the last COLO mode info after failover

[Zhang, Chen]

> -----Original Message-----
> From: Eric Blake [mailto:address@hidden
> Sent: Tuesday, March 26, 2019 10:41 PM
> To: Juan Quintela <address@hidden>; address@hidden
> Cc: Dr. David Alan Gilbert <address@hidden>; zhanghailiang
> <address@hidden>; Markus Armbruster
> <address@hidden>; Zhang, Chen <address@hidden>
> Subject: Re: [PULL 14/15] Migration/colo.c: Make user obtain the last COLO
> mode info after failover
> 
> On 3/25/19 12:47 PM, Juan Quintela wrote:
> > From: Zhang Chen <address@hidden>
> >
> > Add the last_colo_mode to save the status after failover.
> > This patch can solve the issue that user want to get last colo mode
> > use query_colo_status after failover.
> >
> > Signed-off-by: Zhang Chen <address@hidden>
> > Reviewed-by: Juan Quintela <address@hidden>
> > Signed-off-by: Juan Quintela <address@hidden>
> > ---
> 
> > +++ b/qapi/migration.json
> > @@ -1380,12 +1380,17 @@
> >  # @mode: COLO running mode. If COLO is running, this field will return
> >  #        'primary' or 'secondary'.
> >  #
> > +# @last_mode: COLO last running mode. If COLO is running, this field
> > +#             will return same like mode field, after failover we can
> > +#             use this field to get last colo mode. (since 4.1)
> 
> s/4.1/4.0/ - now that this pull request is applied, we'll need a followup 
> patch.
> (Safe for 4.0, as fixing documentation is doable during
> freeze)

OK, I will send a patch for this issue.

Thanks
Zhang Chen

> 
> --
> Eric Blake, Principal Software Engineer
> Red Hat, Inc.           +1-919-301-3226
> Virtualization:  qemu.org | libvirt.org