[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH for 4.1 v2 03/13] tests: acpi: make pointer to RSDP
From: |
Igor Mammedov |
Subject: |
[Qemu-devel] [PATCH for 4.1 v2 03/13] tests: acpi: make pointer to RSDP 64bit |
Date: |
Tue, 26 Mar 2019 14:09:49 +0100 |
In case of UEFI, RSDP doesn't have to be located in lowmem,
it could be placed at any address. Make sure that test won't
break if it is placed above the first 4Gb of address space.
PS:
While at it cleanup some local variables as we don't really
need them.
Signed-off-by: Igor Mammedov <address@hidden>
Reviewed-by: Philippe Mathieu-Daudé <address@hidden>
---
v2:
- s/In case of UEFI/In case of UEFI,/ (Laszlo Ersek <address@hidden>)
---
tests/bios-tables-test.c | 10 ++++------
1 file changed, 4 insertions(+), 6 deletions(-)
diff --git a/tests/bios-tables-test.c b/tests/bios-tables-test.c
index 2ee044c..c29dcf4 100644
--- a/tests/bios-tables-test.c
+++ b/tests/bios-tables-test.c
@@ -26,7 +26,7 @@
typedef struct {
const char *machine;
const char *variant;
- uint32_t rsdp_addr;
+ uint64_t rsdp_addr;
uint8_t rsdp_table[36 /* ACPI 2.0+ RSDP size */];
GArray *tables;
uint32_t smbios_ep_addr;
@@ -86,13 +86,11 @@ static void test_acpi_rsdp_address(test_data *data)
static void test_acpi_rsdp_table(test_data *data)
{
- uint8_t *rsdp_table = data->rsdp_table, revision;
- uint32_t addr = data->rsdp_addr;
+ uint8_t *rsdp_table = data->rsdp_table;
- acpi_fetch_rsdp_table(data->qts, addr, rsdp_table);
- revision = rsdp_table[15 /* Revision offset */];
+ acpi_fetch_rsdp_table(data->qts, data->rsdp_addr, rsdp_table);
- switch (revision) {
+ switch (rsdp_table[15 /* Revision offset */]) {
case 0: /* ACPI 1.0 RSDP */
/* With rev 1, checksum is only for the first 20 bytes */
g_assert(!acpi_calc_checksum(rsdp_table, 20));
--
2.7.4
- Re: [Qemu-devel] [PATCH for 4.1 v2 10/13] tests: acpi: add simple arm/virt testcase, (continued)
- [Qemu-devel] [PATCH for 4.1 v2 03/13] tests: acpi: make pointer to RSDP 64bit,
Igor Mammedov <=
- [Qemu-devel] [PATCH for 4.1 v2 07/13] tests: acpi: add acpi_find_rsdp_address_uefi() helper, Igor Mammedov, 2019/03/26
- [Qemu-devel] [PATCH for 4.1 v2 05/13] tests: acpi: skip FACS table if board uses hw reduced ACPI profile, Igor Mammedov, 2019/03/26
- [Qemu-devel] [PATCH for 4.1 v2 04/13] tests: acpi: fetch X_DSDT if pointer to DSDT is 0, Igor Mammedov, 2019/03/26
- [Qemu-devel] [PATCH for 4.1 v2 01/13] tests: acpi: make RSDT test routine handle XSDT, Igor Mammedov, 2019/03/26
- [Qemu-devel] [PATCH for 4.1 v2 02/13] tests: acpi: rename acpi_parse_rsdp_table() into acpi_fetch_rsdp_table(), Igor Mammedov, 2019/03/26