Re: [Qemu-devel] [Qemu-block] [PATCH] block/vhdx: Use IEC binary prefixes from "qemu/units.h"

[Stefano Garzarella]

On Tue, Mar 26, 2019 at 10:13:54AM +0100, Kevin Wolf wrote:
> Am 26.03.2019 um 08:55 hat Stefano Garzarella geschrieben:
> > On Mon, Mar 25, 2019 at 10:56:57PM +0100, Philippe Mathieu-Daudé wrote:
> > > Le lun. 25 mars 2019 21:53, John Snow <address@hidden> a écrit :
> > > > On 3/21/19 5:40 AM, Stefano Garzarella wrote:
> > > > >  #define DEFAULT_LOG_SIZE 1048576 /* 1MiB */
> > > >
> > > 
> > > Can we also update this definition?
> > > 
> > 
> > Sure, I'll update it in v2.
> 
> This is used in vhdx_create_opts:
> 
>     .def_value_str = stringify(DEFAULT_LOG_SIZE),
> 
> You want the default size to be a number, not an expression, so you'd
> have to change the default string to retain the number. Probably better
> to just leave the #define alone.
> 
> We could, however, put a comment next to the define lik vdi.c has:
> 
>     /* Note: can't use 1 * MiB, because it's passed to stringify() */

Many thanks for this suggestion!
I'll put the comment next to the define.

Thanks,
Stefano