Re: [Qemu-devel] [PATCH for-4.0] gdbstub: fix vCont packet handling when no thread is specified

[Richard Henderson]

On 3/25/19 4:04 AM, Luc Michel wrote:
> The vCont packet accepts a series of actions, each being applied on a
> given thread ID. Giving no thread ID for an action is valid and means
> "all threads".
> 
> This commit fixes vCont packets being incorrectly rejected when no
> thread ID was given for an action.
> 
> In multiprocess mode, the GDB Remote Protocol specification is unclear
> on what "all threads" means. We choose to apply the action on all
> threads of all attached processes.
> 
> This commit is based on the initial fix by Lucien Murray-Pitts.
> 
> Fixes: e40e5204af8388
> Reported-by: Lucien Murray-Pitts <address@hidden>
> Reported-by: Jan Kiszka <address@hidden>
> Signed-off-by: Luc Michel <address@hidden>
> ---
>  gdbstub.c | 14 ++++++++++++--
>  1 file changed, 12 insertions(+), 2 deletions(-)

Reviewed-by: Richard Henderson <address@hidden>


r~