Re: [Qemu-devel] [Qemu-ppc] [RFC for-4.1 00/25] Many style fixes for target/ppc

[Greg Kurz]

On Fri, 22 Mar 2019 11:15:19 +1100
David Gibson <address@hidden> wrote:

> target/ppc has a lot of old code that doesn't stick to the modern
> style guidelines.  That means we keep getting checkpatch warnings from
> code motions in there, or from people copying the local style rather
> than the global style.
> 
> I'm sick of it, so here's a big series to fix many of the style
> problems in target/ppc.
> 
> It doesn't cover every checkpatch warning: outright false positives
> are ignored of course, but there are also some things that it's not
> obvious how to fix (often involving hairy nested macros).  Still, it's
> a good start.
> 

Very nice cleanup ! :)

I've sent some comments to make some cosmetic suggestions, but the
series is already ok for me, so:

Reviewed-by: Greg Kurz <address@hidden>

for the whole series, with or without my suggestions.

> Alexey Kardashevskiy (1):
>   spapr: Support NVIDIA V100 GPU with NVLink2
> 
> David Gibson (23):
>   target/ppc: Style fixes for ppc-models.[ch]
>   target/ppc: Style fixes for cpu.[ch]
>   target/ppc: Style fixes for int_helper.c
>   target/ppc: Style fixes for fpu_helper.c
>   target/ppc: Style fixes for dfp_helper.c
>   target/ppc: Style fixes for excp_helper.c
>   target/ppc: Style fixes for gdbstub.c
>   target/ppc: Style fixes for helper_regs.h
>   target/ppc: Style fixes for kvm_ppc.h and kvm.c
>   target/ppc: Style fixes for machine.c
>   target/ppc: Style fixes for mem_helper.c
>   target/ppc: Style fixes for mfrom_table.inc.c & mfrom_table_gen.c
>   target/ppc: Style fixes for misc_helper.c
>   target/ppc: Style fixes for mmu-hash32.[ch]
>   target/ppc: Style fixes for mmu-hash64.[ch]
>   target/ppc: Style fixes for mmu_helper.c
>   target/ppc: Style fixes for monitor.c
>   target/ppc: Style fixes for translate_init.inc.c
>   target/ppc: Style fixes for translate.c
>   target/ppc: Style fixes for translate/fp-impl.inc.c
>   target/ppc: Style fixes for translate/vsx-impl.inc.c
>   target/ppc: Style fixes for translate/vmx-impl.inc.c
>   target/ppc: Style fixes for translate/spe-impl.inc.c
> 
> Philippe Mathieu-Daudé (1):
>   hw/ppc/prep: Drop useless inclusion of "hw/input/i8042.h"
> 
>  hw/ppc/Makefile.objs                |   2 +-
>  hw/ppc/prep.c                       |   1 -
>  hw/ppc/spapr.c                      |  48 ++-
>  hw/ppc/spapr_pci.c                  |  19 ++
>  hw/ppc/spapr_pci_nvlink2.c          | 450 ++++++++++++++++++++++++
>  hw/vfio/pci-quirks.c                | 131 +++++++
>  hw/vfio/pci.c                       |  14 +
>  hw/vfio/pci.h                       |   2 +
>  hw/vfio/trace-events                |   4 +
>  include/hw/pci-host/spapr.h         |  45 +++
>  include/hw/ppc/spapr.h              |   5 +-
>  target/ppc/cpu-models.c             |   2 +-
>  target/ppc/cpu-models.h             |   3 +-
>  target/ppc/cpu.h                    | 239 +++++++------
>  target/ppc/dfp_helper.c             |  14 +-
>  target/ppc/excp_helper.c            |  87 +++--
>  target/ppc/fpu_helper.c             | 134 +++++---
>  target/ppc/gdbstub.c                |  34 +-
>  target/ppc/helper_regs.h            |  10 +-
>  target/ppc/int_helper.c             |  70 ++--
>  target/ppc/kvm.c                    | 178 ++++++----
>  target/ppc/kvm_ppc.h                |   3 +-
>  target/ppc/machine.c                | 106 +++---
>  target/ppc/mem_helper.c             |  33 +-
>  target/ppc/mfrom_table.inc.c        |   3 +-
>  target/ppc/mfrom_table_gen.c        |   8 +-
>  target/ppc/misc_helper.c            |   9 +-
>  target/ppc/mmu-hash32.c             |  19 +-
>  target/ppc/mmu-hash64.c             |  62 ++--
>  target/ppc/mmu_helper.c             | 131 ++++---
>  target/ppc/monitor.c                |  13 +-
>  target/ppc/translate.c              | 507 +++++++++++++++++-----------
>  target/ppc/translate/fp-impl.inc.c  |  52 +--
>  target/ppc/translate/spe-impl.inc.c |  14 +-
>  target/ppc/translate/vmx-impl.inc.c |  26 +-
>  target/ppc/translate/vsx-impl.inc.c |  15 +-
>  target/ppc/translate_init.inc.c     | 240 +++++++------
>  37 files changed, 1921 insertions(+), 812 deletions(-)
>  create mode 100644 hw/ppc/spapr_pci_nvlink2.c
>