[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [RFC for-4.1 10/25] target/ppc: Style fixes for helper_
From: |
Cédric Le Goater |
Subject: |
Re: [Qemu-devel] [RFC for-4.1 10/25] target/ppc: Style fixes for helper_regs.h |
Date: |
Mon, 25 Mar 2019 07:33:30 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.4.0 |
On 3/22/19 1:15 AM, David Gibson wrote:
> Signed-off-by: David Gibson <address@hidden>
Reviewed-by: Cédric Le Goater <address@hidden>
Thanks,
C.
> ---
> target/ppc/helper_regs.h | 10 ++++++----
> 1 file changed, 6 insertions(+), 4 deletions(-)
>
> diff --git a/target/ppc/helper_regs.h b/target/ppc/helper_regs.h
> index a2205e1044..8397819dee 100644
> --- a/target/ppc/helper_regs.h
> +++ b/target/ppc/helper_regs.h
> @@ -44,10 +44,11 @@ static inline void hreg_swap_gpr_tgpr(CPUPPCState *env)
>
> static inline void hreg_compute_mem_idx(CPUPPCState *env)
> {
> - /* This is our encoding for server processors. The architecture
> + /*
> + * This is our encoding for server processors. The architecture
> * specifies that there is no such thing as userspace with
> - * translation off, however it appears that MacOS does it and
> - * some 32-bit CPUs support it. Weird...
> + * translation off, however it appears that MacOS does it and some
> + * 32-bit CPUs support it. Weird...
> *
> * 0 = Guest User space virtual mode
> * 1 = Guest Kernel space virtual mode
> @@ -143,7 +144,8 @@ static inline int hreg_store_msr(CPUPPCState *env,
> target_ulong value,
> /* Change the exception prefix on PowerPC 601 */
> env->excp_prefix = ((value >> MSR_EP) & 1) * 0xFFF00000;
> }
> - /* If PR=1 then EE, IR and DR must be 1
> + /*
> + * If PR=1 then EE, IR and DR must be 1
> *
> * Note: We only enforce this on 64-bit server processors.
> * It appears that:
>
- [Qemu-devel] [RFC for-4.1 00/25] Many style fixes for target/ppc, David Gibson, 2019/03/21
- [Qemu-devel] [RFC for-4.1 09/25] target/ppc: Style fixes for gdbstub.c, David Gibson, 2019/03/21
- [Qemu-devel] [RFC for-4.1 08/25] target/ppc: Style fixes for excp_helper.c, David Gibson, 2019/03/21
- [Qemu-devel] [RFC for-4.1 11/25] target/ppc: Style fixes for kvm_ppc.h and kvm.c, David Gibson, 2019/03/21
- [Qemu-devel] [RFC for-4.1 10/25] target/ppc: Style fixes for helper_regs.h, David Gibson, 2019/03/21
- Re: [Qemu-devel] [RFC for-4.1 10/25] target/ppc: Style fixes for helper_regs.h,
Cédric Le Goater <=
- [Qemu-devel] [RFC for-4.1 05/25] target/ppc: Style fixes for int_helper.c, David Gibson, 2019/03/21
- [Qemu-devel] [RFC for-4.1 07/25] target/ppc: Style fixes for dfp_helper.c, David Gibson, 2019/03/21
- [Qemu-devel] [RFC for-4.1 12/25] target/ppc: Style fixes for machine.c, David Gibson, 2019/03/21
- [Qemu-devel] [RFC for-4.1 04/25] target/ppc: Style fixes for cpu.[ch], David Gibson, 2019/03/21
- [Qemu-devel] [RFC for-4.1 02/25] hw/ppc/prep: Drop useless inclusion of "hw/input/i8042.h", David Gibson, 2019/03/21
- [Qemu-devel] [RFC for-4.1 06/25] target/ppc: Style fixes for fpu_helper.c, David Gibson, 2019/03/21