[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v1 1/3] configure: add --target-list-exclude
From: |
Alex Bennée |
Subject: |
Re: [Qemu-devel] [PATCH v1 1/3] configure: add --target-list-exclude |
Date: |
Thu, 21 Mar 2019 13:38:46 +0000 |
User-agent: |
mu4e 1.1.0; emacs 26.1 |
Thomas Huth <address@hidden> writes:
> On 19/03/2019 13.47, Alex Bennée wrote:
>> This is an inverse selection which excludes a selected set of targets
>> from the default target list. It will mostly be useful for CI
>> configurations but it might be useful for some users as well.
>
> This will be useful for me, too! For my local builds, I normally drop
> some few targets (e.g. the "duplicated" endianess targets like
> "armeb-linux-user", since I build "arm-linux-user" already), to speed up
> the compilation process a little bit. This will be much easier with this
> new option when I've got to re-run configure again...
>
>> +if test -z "$target_list_exclude"; then
>> + echo "defaults: $target_list_exclude"
>
> That echo line looks like a debug left-over. Remove it?
Oops, yes, will fix.
>
> Apart from that:
>
> Reviewed-by: Thomas Huth <address@hidden>
Thanks.
--
Alex Bennée