qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH 0/8] Clean up #include "..." vs "<...>" and head


From: Stefan Hajnoczi
Subject: Re: [Qemu-devel] [PATCH 0/8] Clean up #include "..." vs "<...>" and header guards
Date: Wed, 20 Mar 2019 13:52:26 +0000
User-agent: Mutt/1.11.3 (2019-02-01)

On Fri, Mar 15, 2019 at 03:51:15PM +0100, Markus Armbruster wrote:
> * Our use of header guards is rather sloppy.  Sloppiness there can
>   lead to confusing compilation errors.  The rest of the series cleans
>   up existing header guards.  In particular, it normalizes guard
>   symbols to follow a common pattern, in the hope of making clashes
>   less likely.  It doesn't add new header guards.  We have more than
>   200 headers without a recognizable header guard.  A few of them are
>   for multiple inclusion, a few more don't need header guards because
>   they don't do anything but include, but the majority probably should
>   have one.  Left for another day.

Time for #pragma once?
https://en.wikipedia.org/wiki/Pragma_once

Stefan

Attachment: signature.asc
Description: PGP signature


reply via email to

[Prev in Thread] Current Thread [Next in Thread]