Re: [Qemu-devel] [PATCH] qemu-pr-helper: check the return value of fcntl in do_pr_out

[no-reply]

Patchew URL: https://patchew.org/QEMU/address@hidden/



Hi,

This series seems to have some coding style problems. See output below for
more information:

Type: series
Message-id: address@hidden
Subject: [Qemu-devel] [PATCH] qemu-pr-helper: check the return value of fcntl 
in do_pr_out

=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===

From https://github.com/patchew-project/qemu
 * [new tag]         patchew/address@hidden -> patchew/address@hidden
Switched to a new branch 'test'
5dcbf97 qemu-pr-helper: check the return value of fcntl in do_pr_out

=== OUTPUT BEGIN ===
ERROR: braces {} are necessary for all arms of this statement
#24: FILE: scsi/qemu-pr-helper.c:557:
+    if (flags < 0)
[...]

ERROR: trailing statements should be on next line
#27: FILE: scsi/qemu-pr-helper.c:560:
+    if ((unsigned int) flags & O_ACCMODE) == O_RDONLY) {

total: 2 errors, 0 warnings, 14 lines checked

Commit 5dcbf975925b (qemu-pr-helper: check the return value of fcntl in 
do_pr_out) has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
=== OUTPUT END ===

Test command exited with code: 1


The full log is available at
http://patchew.org/logs/address@hidden/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to address@hidden