[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH v8 2/7] virtio: Use started flag in virtio_vmstate_c
From: |
elohimes |
Subject: |
[Qemu-devel] [PATCH v8 2/7] virtio: Use started flag in virtio_vmstate_change() |
Date: |
Wed, 20 Mar 2019 19:26:41 +0800 |
From: Xie Yongji <address@hidden>
Currently, we use DRIVER_OK status bit to check whether guest
driver has started the device in virtio_vmstate_change(). But it's
not the case for virtio 1.0 transitional devices. If migration completes
between kicking virtqueue and setting VIRTIO_CONFIG_S_DRIVER_OK, guest
may be hung. So here we use started flag to check guest state instead.
Signed-off-by: Xie Yongji <address@hidden>
Signed-off-by: Zhang Yu <address@hidden>
---
hw/virtio/virtio.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/hw/virtio/virtio.c b/hw/virtio/virtio.c
index af7b59b4ae..b8d36cd4b7 100644
--- a/hw/virtio/virtio.c
+++ b/hw/virtio/virtio.c
@@ -2291,7 +2291,7 @@ static void virtio_vmstate_change(void *opaque, int
running, RunState state)
VirtIODevice *vdev = opaque;
BusState *qbus = qdev_get_parent_bus(DEVICE(vdev));
VirtioBusClass *k = VIRTIO_BUS_GET_CLASS(qbus);
- bool backend_run = running && (vdev->status & VIRTIO_CONFIG_S_DRIVER_OK);
+ bool backend_run = running && vdev->started;
vdev->vm_running = running;
if (backend_run) {
--
2.17.1
- [Qemu-devel] [PATCH v8 0/7] vhost-user-blk: Add support for backend reconnecting, elohimes, 2019/03/20
- [Qemu-devel] [PATCH v8 1/7] virtio: Introduce started flag to VirtioDevice, elohimes, 2019/03/20
- [Qemu-devel] [PATCH v8 2/7] virtio: Use started flag in virtio_vmstate_change(),
elohimes <=
- [Qemu-devel] [PATCH v8 3/7] vhost-user-blk: Use started flag in vhost_user_blk_set_status(), elohimes, 2019/03/20
- [Qemu-devel] [PATCH v8 4/7] vhost-user-blk: Only start vhost-user backend with the first kick, elohimes, 2019/03/20
- [Qemu-devel] [PATCH v8 5/7] vhost-user-blk: Add return value for vhost_user_blk_start(), elohimes, 2019/03/20
- [Qemu-devel] [PATCH v8 6/7] vhost-user-blk: Add support to reconnect backend, elohimes, 2019/03/20
- [Qemu-devel] [PATCH v8 7/7] contrib/vhost-user-blk: enable inflight I/O tracking, elohimes, 2019/03/20