Re: [Qemu-devel] [PATCH] target/mips: Fix minor bug in FPU

[Mateja Marjanovic]

On 18.3.19. 20:08, Aleksandar Markovic wrote:
> > From: Mateja Marjanovic <address@hidden>
> > Subject: [PATCH] target/mips: Fix minor bug in FPU
> >
> > From: Mateja Marjanovic <address@hidden>
> >
> > Wrong type of NaN was generated for IEEE754-2008 by maddf and
> > msubf insturctions when the arguments were inf, zero, nan or
> > zero, inf, nan respectively.
> "insturctions" -> "instructions".
Typo, I will correct that.
> The word "respectively" is here wrong and spurious.
>
> The meaning that you convey with the current wording is that
> the "inf, zero, nan" case is related to "maddf" (only), and the
> "zero, inf, nan" to "msubf".
Could you tell me what do you suggest?

Does "Wrong type of NaN was generated for IEEE754-2008 by maddf and msubf

insturctions when the arguments were (inf, zero, nan) or

(zero, inf, nan)." seem ok?

> Please use full instruction names with possible Backus-Naur
> shorthands, like "MADDF.<D|S>", "MSUBF.<D|S>".
Ok, I will use that from now on.
> Thanks,
> Aleksandar
Thanks,
Mateja