Re: [Qemu-devel] [PATCH] spapr: Remove NULL checks on error_propagate() calls

[David Gibson]

On Mon, Mar 18, 2019 at 08:01:48PM +0100, Markus Armbruster wrote:
> Patch created mechanically by rerunning:
> 
>   $  spatch --sp-file scripts/coccinelle/error_propagate_null.cocci \
>           --macro-file scripts/cocci-macro-file.h \
>           --dir . --in-place
> 
> Signed-off-by: Markus Armbruster <address@hidden>

Applied to ppc-for-4.0, thanks.

> ---
>  hw/ppc/spapr_pci.c | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
> 
> diff --git a/hw/ppc/spapr_pci.c b/hw/ppc/spapr_pci.c
> index 20915d2b3c..b63ed9d8da 100644
> --- a/hw/ppc/spapr_pci.c
> +++ b/hw/ppc/spapr_pci.c
> @@ -1488,9 +1488,7 @@ static void spapr_pci_plug(HotplugHandler *plug_handler,
>      }
>  
>  out:
> -    if (local_err) {
> -        error_propagate(errp, local_err);
> -    }
> +    error_propagate(errp, local_err);
>  }
>  
>  static void spapr_pci_unplug(HotplugHandler *plug_handler,

-- 
David Gibson                    | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au  | minimalist, thank you.  NOT _the_ _other_
                                | _way_ _around_!
http://www.ozlabs.org/~dgibson

signature.asc
Description: PGP signature