Re: [Qemu-devel] [PATCH v2 09/11] hw/acpi: Add ACPI Generic Event Device Support

[Igor Mammedov]

On Mon, 18 Mar 2019 15:04:28 +0000
Shameerali Kolothum Thodi <address@hidden> wrote:

> Hi Igor,
> 
> > -----Original Message-----
> > From: Igor Mammedov [mailto:address@hidden
> > Sent: 18 March 2019 12:26
> > To: Shameerali Kolothum Thodi <address@hidden>
> > Cc: address@hidden; address@hidden;
> > address@hidden; address@hidden;
> > address@hidden; address@hidden;
> > address@hidden; Linuxarm <address@hidden>; xuwei (O)
> > <address@hidden>
> > Subject: Re: [PATCH v2 09/11] hw/acpi: Add ACPI Generic Event Device Support
> > 
> > On Fri, 8 Mar 2019 11:42:16 +0000
> > Shameer Kolothum <address@hidden> wrote:
> >   
> > > From: Samuel Ortiz <address@hidden>
> > >
> > > The ACPI Generic Event Device (GED) is a hardware-reduced specific
> > > device that handles all platform events, including the hotplug ones.
> > > This patch generate the AML code that defines GEDs.
> > > Platforms need to specify their own GedEvent array to describe what kind
> > > of events they want to support through GED. The build_ged_aml routine
> > > takes a GedEvent array that maps a specific GED event to an IRQ number.
> > > Then we use that array to build both the _CRS and the _EVT section
> > > of the GED device.  
> > 
> > I'd this a part of "virtual ACPI device"  
> 
> Just to confirm, you meant, instead of separate virt-acpi.c and ged.c, move 
> the
> contents of this patch into "virtual ACPI device" implementation (something 
> like 
> hw/acpi/generic-event-device.c) ?
yep, and only moving bit making hw related routines form virt-acpi.c
a part of ged device model where they are called at appropriate times 
like initfn/realize or property setting time.

Then ACPI functions (not part of device but could be in the same file)
would fetch all necessary data from ged device and generate AML code from it.

> 
> Please let me know.
> 
> Thanks,
> Shameer
> 
> > > This is in preparation for making use of GED for ARM/virt
> > > platform and for now supports only memory hotplug.
> > >
> > > Signed-off-by: Samuel Ortiz <address@hidden>
> > > Signed-off-by: Sebastien Boeuf <address@hidden>
> > > Signed-off-by: Shameer Kolothum <address@hidden>
> > > ---  
> > [...]