Re: [Qemu-devel] [PATCH v2] xen-mapcache: use MAP_FIXED flag so the mmap address hint is always honored

[Paul Durrant]

> -----Original Message-----
> From: Anthony PERARD [mailto:address@hidden
> Sent: 18 March 2019 16:35
> To: Igor Druzhinin <address@hidden>
> Cc: Roger Pau Monne <address@hidden>; address@hidden; Stefano Stabellini
> <address@hidden>; Paul Durrant <address@hidden>; Paolo Bonzini 
> <address@hidden>;
> Richard Henderson <address@hidden>; Eduardo Habkost <address@hidden>; Michael 
> S. Tsirkin
> <address@hidden>; Marcel Apfelbaum <address@hidden>; address@hidden
> Subject: Re: [PATCH v2] xen-mapcache: use MAP_FIXED flag so the mmap address 
> hint is always honored
> 
> On Mon, Mar 18, 2019 at 03:48:59PM +0000, Igor Druzhinin wrote:
> > On 18/03/2019 15:45, Roger Pau Monne wrote:
> > > diff --git a/hw/i386/xen/xen-mapcache.c b/hw/i386/xen/xen-mapcache.c
> > > index 349f72d00c..23de5517db 100644
> > > --- a/hw/i386/xen/xen-mapcache.c
> > > +++ b/hw/i386/xen/xen-mapcache.c
> > > @@ -185,8 +185,13 @@ static void xen_remap_bucket(MapCacheEntry *entry,
> > >      }
> > >
> > >      if (!dummy) {
> > > +        /*
> > > +         * If the caller has requested the mapping at a specific address 
> > > use
> > > +         * MAP_FIXED to make sure it's honored.
> > > +         */
> >
> > Since the comment now applied to both invocation - could it be moved
> > outside the if statement then?
> 
> That sounds good to me.

I have no problem and my R-b still stands.

  Paul

> 
> --
> Anthony PERARD