Re: [Qemu-devel] [RFC PATCH 8/8] hw/isa/Kconfig: Complete the VT82C686B southbridge config

[Philippe Mathieu-Daudé]

On 3/17/19 1:22 AM, Philippe Mathieu-Daudé wrote:
> Complete the VT82C686B southbridge Kconfig entry. For clarity, add
> the SuperIO dependencies in an internal config: VT82C686_SUPERIO.
> 
> Signed-off-by: Philippe Mathieu-Daudé <address@hidden>
> ---
> RFC because APIC/IOAPIC are still linked to X86

And because I let 'TODO' and Thomas doesn't like TODO ;)

The patch works without the TODO/FIXME fixed. So Paolo, feel free to
take it if you like it :)

Regards,

Phil.

> ---
>  hw/isa/Kconfig | 26 +++++++++++++++++++++++---
>  1 file changed, 23 insertions(+), 3 deletions(-)
> 
> diff --git a/hw/isa/Kconfig b/hw/isa/Kconfig
> index 19101d349f..efe0cdedc7 100644
> --- a/hw/isa/Kconfig
> +++ b/hw/isa/Kconfig
> @@ -30,12 +30,32 @@ config PIIX4
>      # for PIIX4.
>      select ISA_BUS
>  
> +config VT82C686_SUPERIO
> +    select SERIAL_ISA
> +    select PARALLEL
> +    select FDC
> +    # TODO AC97
> +    select SMBUS
> +    select APM
> +    select ACPI
> +    select ACPI_SMBUS
> +    # FIXME APIC/IOAPIC requires X86
> +    select APIC if PC
> +    select IOAPIC if PC
> +
>  config VT82C686
>      bool
> +    select PCI
>      select ISA_BUS
> -    select ACPI_SMBUS
> -    select SERIAL_ISA
> -    select FDC
> +    select I8257
> +    select I8254
> +    select I8259
> +    select I8042
> +    # TODO DS12885 RTC
> +    select USB_UHCI
> +    select IDE_PCI
> +    select IDE_VIA
> +    select VT82C686_SUPERIO
>  
>  config SMC37C669
>      bool
>