Re: [Qemu-devel] [PATCH v3 00/23] Add qemu_getrandom and ARMv8.5-RNG etc

[Daniel P . Berrangé]

On Thu, Mar 14, 2019 at 08:26:06PM -0700, Richard Henderson wrote:
> Changes since v2:
>   * Changes from review.
>     - getrandom is not exclusive of /dev/urandom fallback.
>     - vnc fails gracefully on crypto failure.
>     - a great renaming.
>   * Drop the "nonblock" argument, as it's not deliverable from the backend.
>   * Propagate Error back through qemu_guest_getrandom.
>   * Add qemu_guest_getrandom_nofail to centralize "Argh! Death!".
>   * Convert hw/misc/
>   * Implement ppc darn.
>   * Implement x86 rdrand.
> 
> Changes since v1:
>   * Build crypto-obj-y for linux-user as well.
>   * Several patches to tidy crypto/random-platform.c.
>   * Use getrandom(2) in crypto/random-platform.c.
>   * Use qcrypto_random_bytes in ui/vnc.c.
>   * In qemu_getrandom:
>     - Use g_rand_int instead of srand48.
>     - Use qcrypto_random_bytes instead of getrandom directly.
> 
> 
> r~
> 
> 
> Richard Henderson (23):
>   crypto: Merge crypto-obj-y into libqemuutil.a
>   crypto: Reverse code blocks in random-platform.c
>   crypto: Do not fail for EINTR during qcrypto_random_bytes
>   crypto: Use O_CLOEXEC in qcrypto_random_init
>   crypto: Use getrandom for qcrypto_random_bytes
>   crypto: Change the qcrypto_random_bytes buffer type to void*

Once the full series is acked, I'm fine if you want to do a
pull request with the whole series. If not, I'll take the
crypto patches into my pending queue.

>   ui/vnc: Split out authentication_failure
>   ui/vnc: Use gcrypto_random_bytes for start_auth_vnc
>   util: Add qemu_guest_getrandom and associated routines
>   cpus: Initialize pseudo-random seeds for all guest cpus
>   linux-user: Initialize pseudo-random seeds for all guest cpus
>   linux-user: Call qcrypto_init if not using -seed
>   linux-user: Use qemu_guest_getrandom_nofail for AT_RANDOM
>   linux-user/aarch64: Use qemu_guest_getrandom for PAUTH keys
>   linux-user: Remove srand call
>   aspeed/scu: Use qemu_guest_getrandom_nofail
>   hw/misc/nrf51_rng: Use qemu_guest_getrandom_nofail
>   hw/misc/bcm2835_rng: Use qemu_guest_getrandom_nofail
>   hw/misc/exynos4210_rng: Use qemu_guest_getrandom
>   target/arm: Put all PAC keys into a structure
>   target/arm: Implement ARMv8.5-RNG
>   target/ppc: Use qemu_guest_getrandom for DARN
>   target/i386: Implement CPUID_EXT_RDRAND

Regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|