[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v3 07/23] ui/vnc: Split out authentication_failu
From: |
Daniel P . Berrangé |
Subject: |
Re: [Qemu-devel] [PATCH v3 07/23] ui/vnc: Split out authentication_failure |
Date: |
Fri, 15 Mar 2019 14:44:36 +0000 |
User-agent: |
Mutt/1.11.3 (2019-02-01) |
On Thu, Mar 14, 2019 at 08:26:13PM -0700, Richard Henderson wrote:
> There were 3 copies of this code, one of which used the wrong
> data size for the failure indicator.
>
> Cc: Gerd Hoffmann <address@hidden>
> Signed-off-by: Richard Henderson <address@hidden>
> ---
> ui/vnc.c | 37 +++++++++++++++----------------------
> 1 file changed, 15 insertions(+), 22 deletions(-)
Reviewed-by: Daniel P. Berrangé <address@hidden>
Regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
- Re: [Qemu-devel] [PATCH v3 08/23] ui/vnc: Use gcrypto_random_bytes for start_auth_vnc, (continued)
- [Qemu-devel] [PATCH v3 04/23] crypto: Use O_CLOEXEC in qcrypto_random_init, Richard Henderson, 2019/03/14
- [Qemu-devel] [PATCH v3 02/23] crypto: Reverse code blocks in random-platform.c, Richard Henderson, 2019/03/14
- [Qemu-devel] [PATCH v3 16/23] aspeed/scu: Use qemu_guest_getrandom_nofail, Richard Henderson, 2019/03/14
- [Qemu-devel] [PATCH v3 14/23] linux-user/aarch64: Use qemu_guest_getrandom for PAUTH keys, Richard Henderson, 2019/03/14
- [Qemu-devel] [PATCH v3 11/23] linux-user: Initialize pseudo-random seeds for all guest cpus, Richard Henderson, 2019/03/14
- [Qemu-devel] [PATCH v3 07/23] ui/vnc: Split out authentication_failure, Richard Henderson, 2019/03/14
- [Qemu-devel] [PATCH v3 15/23] linux-user: Remove srand call, Richard Henderson, 2019/03/14
- [Qemu-devel] [PATCH v3 10/23] cpus: Initialize pseudo-random seeds for all guest cpus, Richard Henderson, 2019/03/14
- [Qemu-devel] [PATCH v3 06/23] crypto: Change the qcrypto_random_bytes buffer type to void*, Richard Henderson, 2019/03/14
- [Qemu-devel] [PATCH v3 17/23] hw/misc/nrf51_rng: Use qemu_guest_getrandom_nofail, Richard Henderson, 2019/03/14
- [Qemu-devel] [PATCH v3 09/23] util: Add qemu_guest_getrandom and associated routines, Richard Henderson, 2019/03/14
- [Qemu-devel] [PATCH v3 12/23] linux-user: Call qcrypto_init if not using -seed, Richard Henderson, 2019/03/14
- [Qemu-devel] [PATCH v3 05/23] crypto: Use getrandom for qcrypto_random_bytes, Richard Henderson, 2019/03/14