Re: [Qemu-devel] [PATCH v2 01/14] crypto: Merge crypto-obj-y into libqemuutil.a

[Daniel P . Berrangé]

On Thu, Mar 14, 2019 at 10:54:49AM -0700, Richard Henderson wrote:
> On 3/14/19 8:43 AM, Daniel P. Berrangé wrote:
> > I think this needs to replace  test-crypto-obj-y with test-util-obj-y
> > in tests/Makefile.include too
> 
> test-crypto-obj-y = $(authz-obj-y) $(crypto-obj-y) $(test-qom-obj-y)

Hmm, the crypto stuff depends on the authz and qom code, and
authz-obj-y is only added to the softmmu impls. I guess the
linux-user still links ok because the linker drops any .o
members from libqemuutil.a that aren't referenced in the final
binary. qom-obj-y is added to linux-user explicitly so that.

Overall it feels like libqemuutil.a probably ought to have
all of authz-obj-y, crypto-obj-y and qom-obj-y included by
default so we can just remove the repetition in the make
rules.

Don't feel obliged to tackle that bigger cleanup though.
I'm fine if that's left for another day.

> 
> While I could replace crypto-obj-y with test-util-obj-y:
> 
>   test-util-obj-y = libqemuutil.a
> 
> the full variable still contains extra stuff.

Regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|