Re: [Qemu-devel] [PATCH] curses ui: add missing iconv_close

[Peter Maydell]

On Thu, 14 Mar 2019 at 17:27, Samuel Thibault <address@hidden> wrote:
>
> Peter Maydell, le jeu. 14 mars 2019 17:21:54 +0000, a ecrit:
> > On Thu, 14 Mar 2019 at 17:20, Samuel Thibault
> > <address@hidden> wrote:
> > >
> > > Signed-off-by: Samuel Thibault <address@hidden>
> > > ---
> > >  ui/curses.c | 1 +
> > >  1 file changed, 1 insertion(+)
> > >
> > > diff --git a/ui/curses.c b/ui/curses.c
> > > index 3a7e8649f3..1f83a15a1c 100644
> > > --- a/ui/curses.c
> > > +++ b/ui/curses.c
> > > @@ -646,6 +646,7 @@ static void font_setup(void)
> > >              }
> > >          }
> > >      }
> > > +    iconv_close(ucs_to_wchar_conv);
> > >  }
> >
> > Don't you need to iconv_close() font_conv and
> > wchar_to_ucs_conv as well ?
>
> Right, sorry, since I didn't have coverity access I didn't realize there
> were three leaks.

I did mention all 3 variables in my email about the issue :-)

thanks
-- PMM