qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH] curses ui: add missing iconv_close


From: Peter Maydell
Subject: Re: [Qemu-devel] [PATCH] curses ui: add missing iconv_close
Date: Thu, 14 Mar 2019 17:21:54 +0000

On Thu, 14 Mar 2019 at 17:20, Samuel Thibault
<address@hidden> wrote:
>
> The iconv_t is opened but never closed.
>
> Spotted by Coverity: CID 1399708
> Spotted by Coverity: CID 1399709
> Spotted by Coverity: CID 1399713
>
> Signed-off-by: Samuel Thibault <address@hidden>
> ---
>  ui/curses.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/ui/curses.c b/ui/curses.c
> index 3a7e8649f3..1f83a15a1c 100644
> --- a/ui/curses.c
> +++ b/ui/curses.c
> @@ -646,6 +646,7 @@ static void font_setup(void)
>              }
>          }
>      }
> +    iconv_close(ucs_to_wchar_conv);
>  }

Don't you need to iconv_close() font_conv and
wchar_to_ucs_conv as well ?

thanks
-- PMM



reply via email to

[Prev in Thread] Current Thread [Next in Thread]