[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH v5 3/5] Acceptance tests: add the build directory to
From: |
Cleber Rosa |
Subject: |
[Qemu-devel] [PATCH v5 3/5] Acceptance tests: add the build directory to the system PATH |
Date: |
Wed, 13 Mar 2019 16:46:09 -0400 |
So that when binaries such as qemu-img are searched for, those in the
build tree will be favored. As a clarification, SRC_ROOT_DIR is
dependent on the location from where tests are executed, so they are
equal to the build directory if one is being used.
The original motivation is that Avocado libraries such as
avocado.utils.vmimage.get() may use the matching binaries, but it may
also apply to any other binary that test code may eventually attempt
to execute.
Signed-off-by: Cleber Rosa <address@hidden>
---
tests/acceptance/avocado_qemu/__init__.py | 6 ++++++
1 file changed, 6 insertions(+)
diff --git a/tests/acceptance/avocado_qemu/__init__.py
b/tests/acceptance/avocado_qemu/__init__.py
index 7b5d828584..a91e1202b8 100644
--- a/tests/acceptance/avocado_qemu/__init__.py
+++ b/tests/acceptance/avocado_qemu/__init__.py
@@ -42,6 +42,12 @@ def pick_default_qemu_bin():
class Test(avocado.Test):
def setUp(self):
+ # Some utility code uses binaries from the system's PATH. For
+ # instance, avocado.utils.vmimage.get() uses qemu-img, to
+ # create a snapshot image. This is a transparent way of
+ # making sure those utilities find and use binaries on the
+ # build tree by default.
+ os.environ['PATH'] = '%s:%s' % (SRC_ROOT_DIR, os.environ['PATH'])
self._vms = {}
self.qemu_bin = self.params.get('qemu_bin',
default=pick_default_qemu_bin())
--
2.20.1
- [Qemu-devel] [PATCH v5 0/5] Add "boot_linux" acceptance test, Cleber Rosa, 2019/03/13
- [Qemu-devel] [PATCH v5 2/5] Acceptance tests: keep a stable reference to the QEMU build dir, Cleber Rosa, 2019/03/13
- [Qemu-devel] [PATCH v5 1/5] Acceptance tests: use relative location for tests, Cleber Rosa, 2019/03/13
- [Qemu-devel] [PATCH v5 3/5] Acceptance tests: add the build directory to the system PATH,
Cleber Rosa <=
- [Qemu-devel] [PATCH v5 4/5] Acceptance tests: depend on qemu-img, Cleber Rosa, 2019/03/13
- [Qemu-devel] [PATCH v5 5/5] Add "boot_linux" acceptance test for x86_64 and pc machine type, Cleber Rosa, 2019/03/13
- Re: [Qemu-devel] [PATCH v5 0/5] Add "boot_linux" acceptance test, no-reply, 2019/03/13
- Re: [Qemu-devel] [PATCH v5 0/5] Add "boot_linux" acceptance test, Wainer dos Santos Moschetta, 2019/03/14