[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v5 00/15] s390: vfio-ccw dasd ipl support
From: |
no-reply |
Subject: |
Re: [Qemu-devel] [PATCH v5 00/15] s390: vfio-ccw dasd ipl support |
Date: |
Wed, 13 Mar 2019 11:13:55 -0700 (PDT) |
Patchew URL: https://patchew.org/QEMU/address@hidden/
Hi,
This series seems to have some coding style problems. See output below for
more information:
Type: series
Message-id: address@hidden
Subject: [Qemu-devel] [PATCH v5 00/15] s390: vfio-ccw dasd ipl support
=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===
Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
t [tag update] patchew/address@hidden -> patchew/address@hidden
t [tag update] patchew/address@hidden -> patchew/address@hidden
Switched to a new branch 'test'
4b8f0d8ca1 s390-bios: Support booting from real dasd device
58d89a48aa s390-bios: Add channel command codes/structs needed for dasd-ipl
27184019e9 s390-bios: Use control unit type to determine boot method
e89de02f38 s390-bios: Refactor virtio to run channel programs via cio
4a9e3f3293 s390-bios: cio error handling
0e3c357024 s390-bios: Support for running format-0/1 channel programs
e026f9363d s390-bios: ptr2u32 and u32toptr
69b1199cb4 s390-bios: Map low core memory
81c99b9681 s390-bios: Decouple channel i/o logic from virtio
8cc7aeaf32 s390-bios: Clean up cio.h
eb50486bcc s390-bios: Factor finding boot device out of virtio code path
f01ef093e9 s390-bios: Extend find_dev() for non-virtio devices
560a2985c0 s390-bios: decouple common boot logic from virtio
c4b6e8b164 s390-bios: decouple cio setup from virtio
2a16b06b29 s390 vfio-ccw: Add bootindex property and IPLB data
=== OUTPUT BEGIN ===
1/15 Checking commit 2a16b06b291d (s390 vfio-ccw: Add bootindex property and
IPLB data)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#221:
new file mode 100644
total: 0 errors, 1 warnings, 199 lines checked
Patch 1/15 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
2/15 Checking commit c4b6e8b16493 (s390-bios: decouple cio setup from virtio)
3/15 Checking commit 560a2985c0e9 (s390-bios: decouple common boot logic from
virtio)
ERROR: externs should be avoided in .c files
#31: FILE: pc-bios/s390-ccw/main.c:19:
+IplParameterBlock iplb __attribute__((__aligned__(PAGE_SIZE)));
total: 1 errors, 0 warnings, 65 lines checked
Patch 3/15 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
4/15 Checking commit f01ef093e92f (s390-bios: Extend find_dev() for non-virtio
devices)
5/15 Checking commit eb50486bcc42 (s390-bios: Factor finding boot device out of
virtio code path)
6/15 Checking commit 8cc7aeaf32a1 (s390-bios: Clean up cio.h)
7/15 Checking commit 81c99b9681c0 (s390-bios: Decouple channel i/o logic from
virtio)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#29:
new file mode 100644
total: 0 errors, 1 warnings, 123 lines checked
Patch 7/15 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
8/15 Checking commit 69b1199cb4d5 (s390-bios: Map low core memory)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#36:
new file mode 100644
total: 0 errors, 1 warnings, 104 lines checked
Patch 8/15 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
9/15 Checking commit e026f9363d16 (s390-bios: ptr2u32 and u32toptr)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#17:
new file mode 100644
total: 0 errors, 1 warnings, 31 lines checked
Patch 9/15 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
10/15 Checking commit 0e3c3570241d (s390-bios: Support for running format-0/1
channel programs)
ERROR: trailing whitespace
#138: FILE: pc-bios/s390-ccw/cio.c:145:
+ * active (generating i/o interrupts). $
total: 1 errors, 0 warnings, 375 lines checked
Patch 10/15 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
11/15 Checking commit 4a9e3f329374 (s390-bios: cio error handling)
12/15 Checking commit e89de02f3828 (s390-bios: Refactor virtio to run channel
programs via cio)
WARNING: line over 80 characters
#104: FILE: pc-bios/s390-ccw/virtio.c:298:
+ run_ccw(vdev, CCW_CMD_READ_VQ_CONF, &config, sizeof(config),
false) == 0,
WARNING: line over 80 characters
#117: FILE: pc-bios/s390-ccw/virtio.c:308:
+ run_ccw(vdev, CCW_CMD_WRITE_STATUS, &status, sizeof(status), false) ==
0,
total: 0 errors, 2 warnings, 115 lines checked
Patch 12/15 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
13/15 Checking commit 27184019e9da (s390-bios: Use control unit type to
determine boot method)
14/15 Checking commit 58d89a48aaa4 (s390-bios: Add channel command
codes/structs needed for dasd-ipl)
15/15 Checking commit 4b8f0d8ca11f (s390-bios: Support booting from real dasd
device)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#26:
new file mode 100644
total: 0 errors, 1 warnings, 447 lines checked
Patch 15/15 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
=== OUTPUT END ===
Test command exited with code: 1
The full log is available at
http://patchew.org/logs/address@hidden/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [http://patchew.org/].
Please send your feedback to address@hidden
- [Qemu-devel] [PATCH v5 04/15] s390-bios: Extend find_dev() for non-virtio devices, (continued)
- [Qemu-devel] [PATCH v5 04/15] s390-bios: Extend find_dev() for non-virtio devices, Jason J. Herne, 2019/03/13
- [Qemu-devel] [PATCH v5 02/15] s390-bios: decouple cio setup from virtio, Jason J. Herne, 2019/03/13
- [Qemu-devel] [PATCH v5 01/15] s390 vfio-ccw: Add bootindex property and IPLB data, Jason J. Herne, 2019/03/13
- [Qemu-devel] [PATCH v5 03/15] s390-bios: decouple common boot logic from virtio, Jason J. Herne, 2019/03/13
- Re: [Qemu-devel] [PATCH v5 00/15] s390: vfio-ccw dasd ipl support, no-reply, 2019/03/13
- Re: [Qemu-devel] [PATCH v5 00/15] s390: vfio-ccw dasd ipl support, no-reply, 2019/03/13
- Re: [Qemu-devel] [PATCH v5 00/15] s390: vfio-ccw dasd ipl support, no-reply, 2019/03/13
- Re: [Qemu-devel] [PATCH v5 00/15] s390: vfio-ccw dasd ipl support, no-reply, 2019/03/13
- Re: [Qemu-devel] [PATCH v5 00/15] s390: vfio-ccw dasd ipl support, no-reply, 2019/03/13
- Re: [Qemu-devel] [PATCH v5 00/15] s390: vfio-ccw dasd ipl support,
no-reply <=
- Re: [Qemu-devel] [PATCH v5 00/15] s390: vfio-ccw dasd ipl support, no-reply, 2019/03/13
- Re: [Qemu-devel] [PATCH v5 00/15] s390: vfio-ccw dasd ipl support, no-reply, 2019/03/13
- Re: [Qemu-devel] [PATCH v5 00/15] s390: vfio-ccw dasd ipl support, no-reply, 2019/03/13
- Re: [Qemu-devel] [PATCH v5 00/15] s390: vfio-ccw dasd ipl support, no-reply, 2019/03/13
- Re: [Qemu-devel] [PATCH v5 00/15] s390: vfio-ccw dasd ipl support, no-reply, 2019/03/13
- Re: [Qemu-devel] [qemu-s390x] [PATCH v5 00/15] s390: vfio-ccw dasd ipl support, Jason J. Herne, 2019/03/20