qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH 3/4] hw/rdma: Use {} instead of {0}


From: Eric Blake
Subject: Re: [Qemu-devel] [PATCH 3/4] hw/rdma: Use {} instead of {0}
Date: Wed, 13 Mar 2019 07:25:07 -0500
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.5.1

On 3/13/19 3:46 AM, Kamal Heib wrote:
> Signed-off-by: Kamal Heib <address@hidden>
> ---
>  hw/rdma/rdma_backend.c      | 18 +++++++++---------
>  hw/rdma/vmw/pvrdma_cmd.c    |  2 +-
>  hw/rdma/vmw/pvrdma_qp_ops.c |  2 +-
>  3 files changed, 11 insertions(+), 11 deletions(-)

{0} is standard C (but some versions of clang have a bug that it
mistakenly warns for certain structs); {} is an extension (but one that
both gcc and clang support).  Did you hit the actual clang bug that
requires this change, or are you only doing it for consistency?

-- 
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3226
Virtualization:  qemu.org | libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature


reply via email to

[Prev in Thread] Current Thread [Next in Thread]