Re: [Qemu-devel] [PATCH 07/10] roms: build edk2 firmware binaries and variable store templates

[Laszlo Ersek]

On 03/12/19 22:11, Philippe Mathieu-Daudé wrote:
> On 3/12/19 4:15 PM, Laszlo Ersek wrote:

>> Phil: can you please test whether SHELL=/bin/bash works for you on
>> Ubuntu? (After you install "bash", of course.)
> 
> It indeed worked using:
> -- >8 --
> @@ -11,6 +11,8 @@
>  # THE PROGRAM IS DISTRIBUTED UNDER THE BSD LICENSE ON AN "AS IS" BASIS,
> WITHOUT
>  # WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER EXPRESS OR IMPLIED.
> 
> +SHELL = /bin/bash
> +
>  toolchain = $(shell source ./edk2-funcs.sh && qemu_edk2_get_toolchain $(1))
> ---
> 
> With this fixup:
> Reviewed-by: Philippe Mathieu-Daudé <address@hidden>
> Tested-by: Philippe Mathieu-Daudé <address@hidden>
> 
> Regards,
> 
> Phil.
> 

Thank you very much!
Laszlo