[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PULL 05/21] migration: Introduce ignore-shared capabil
From: |
Juan Quintela |
Subject: |
Re: [Qemu-devel] [PULL 05/21] migration: Introduce ignore-shared capability |
Date: |
Wed, 13 Mar 2019 10:39:45 +0100 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) |
Markus Armbruster <address@hidden> wrote:
> "Dr. David Alan Gilbert (git)" <address@hidden> writes:
>
>> From: Yury Kotov <address@hidden>
>>
>> We want to use local migration to update QEMU for running guests.
>> In this case we don't need to migrate shared (file backed) RAM.
>> So, add a capability to ignore such blocks during live migration.
>>
>> Signed-off-by: Yury Kotov <address@hidden>
>> Message-Id: <address@hidden>
>> Reviewed-by: Dr. David Alan Gilbert <address@hidden>
>> Signed-off-by: Dr. David Alan Gilbert <address@hidden>
>> ---
> [...]
>> diff --git a/qapi/migration.json b/qapi/migration.json
>> index 1fd7bbea9b..eab87340b2 100644
>> --- a/qapi/migration.json
>> +++ b/qapi/migration.json
>> @@ -409,13 +409,16 @@
>> # devices (and thus take locks) immediately at the end of
>> migration.
>> # (since 3.0)
>> #
>> +# @x-ignore-shared: If enabled, QEMU will not migrate shared memory (since
>> 4.0)
>
> What exactly is considered "shared memory"?
>
> Specifically: say you have an ivshmem-plain device. Is its shared
> memory migrated?
>
> No objection to the pull request; if documentation improvements are
> necessary, we can do them in a follow-up patch.
They migrate to the same host to update the running qemu.
What they are trying to do is to share the guest memory so they don't
have to copy that memory (remember that they are inside the same host).
It is up to you to decide if that is a great idea or "abuse" the
interface (Anyways the change is small enough).
Later, Juan.
- [Qemu-devel] [PULL 00/21] migration queue, Dr. David Alan Gilbert (git), 2019/03/05
- [Qemu-devel] [PULL 01/21] migration: Fix cancel state, Dr. David Alan Gilbert (git), 2019/03/05
- [Qemu-devel] [PULL 03/21] migration/rdma: clang compilation fix, Dr. David Alan Gilbert (git), 2019/03/05
- [Qemu-devel] [PULL 02/21] migration/rdma: Fix qemu_rdma_cleanup null check, Dr. David Alan Gilbert (git), 2019/03/05
- [Qemu-devel] [PULL 04/21] exec: Change RAMBlockIterFunc definition, Dr. David Alan Gilbert (git), 2019/03/05
- [Qemu-devel] [PULL 05/21] migration: Introduce ignore-shared capability, Dr. David Alan Gilbert (git), 2019/03/05
- [Qemu-devel] [PULL 06/21] migration: Add an ability to ignore shared RAM blocks, Dr. David Alan Gilbert (git), 2019/03/05
- [Qemu-devel] [PULL 08/21] migration: Add capabilities validation, Dr. David Alan Gilbert (git), 2019/03/05
- [Qemu-devel] [PULL 07/21] tests/migration-test: Add a test for ignore-shared capability, Dr. David Alan Gilbert (git), 2019/03/05
- [Qemu-devel] [PULL 11/21] tests: Add basic migration precopy tcp test, Dr. David Alan Gilbert (git), 2019/03/05
- [Qemu-devel] [PULL 09/21] tests: Add migration xbzrle test, Dr. David Alan Gilbert (git), 2019/03/05
- [Qemu-devel] [PULL 13/21] bitmap: bitmap_count_one_with_offset, Dr. David Alan Gilbert (git), 2019/03/05
- [Qemu-devel] [PULL 12/21] bitmap: fix bitmap_count_one, Dr. David Alan Gilbert (git), 2019/03/05
- [Qemu-devel] [PULL 14/21] migration: use bitmap_mutex in migration_bitmap_clear_dirty, Dr. David Alan Gilbert (git), 2019/03/05