[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH for-4.1 6/7] ui/vnc: Use qemu_getrandom for make
From: |
Gerd Hoffmann |
Subject: |
Re: [Qemu-devel] [PATCH for-4.1 6/7] ui/vnc: Use qemu_getrandom for make_challenge |
Date: |
Wed, 13 Mar 2019 08:27:31 +0100 |
User-agent: |
NeoMutt/20180716 |
On Tue, Mar 12, 2019 at 11:26:29PM -0700, Richard Henderson wrote:
> Use a better interface for random numbers than rand,
> plus some useless floating point arithmetic.
> - int i;
> -
> - srand(time(NULL)+getpid()+getpid()*987654+rand());
> -
> - for (i = 0 ; i < sizeof(vs->challenge) ; i++)
> - vs->challenge[i] = (int) (256.0*rand()/(RAND_MAX+1.0));
> + qemu_getrandom(vs->challenge, sizeof(vs->challenge), false);
Reviewed-by: Gerd Hoffmann <address@hidden>
- [Qemu-devel] [PATCH for-4.1 0/7] Add qemu_getrandom and ARMv8.5-RNG, Richard Henderson, 2019/03/13
- [Qemu-devel] [PATCH for-4.1 4/7] linux-user/aarch64: Use qemu_getrandom for arm_init_pauth_key, Richard Henderson, 2019/03/13
- [Qemu-devel] [PATCH for-4.1 2/7] util: Use getrandom for qemu_getrandom if available, Richard Henderson, 2019/03/13
- [Qemu-devel] [PATCH for-4.1 5/7] linux-user: Remove srand call, Richard Henderson, 2019/03/13
- [Qemu-devel] [PATCH for-4.1 3/7] linux-user: Use qemu_getrandom for AT_RANDOM, Richard Henderson, 2019/03/13
- [Qemu-devel] [PATCH for-4.1 1/7] util: Add qemu_getrandom and support functions, Richard Henderson, 2019/03/13
- [Qemu-devel] [PATCH for-4.1 6/7] ui/vnc: Use qemu_getrandom for make_challenge, Richard Henderson, 2019/03/13
- Re: [Qemu-devel] [PATCH for-4.1 6/7] ui/vnc: Use qemu_getrandom for make_challenge,
Gerd Hoffmann <=
- [Qemu-devel] [PATCH for-4.1 7/7] target/arm: Implement ARMv8.5-RNG, Richard Henderson, 2019/03/13
- Re: [Qemu-devel] [PATCH for-4.1 0/7] Add qemu_getrandom and ARMv8.5-RNG, no-reply, 2019/03/13
- Re: [Qemu-devel] [PATCH for-4.1 0/7] Add qemu_getrandom and ARMv8.5-RNG, Daniel P . Berrangé, 2019/03/13
- Re: [Qemu-devel] [PATCH for-4.1 0/7] Add qemu_getrandom and ARMv8.5-RNG, Richard Henderson, 2019/03/13
- Re: [Qemu-devel] [PATCH for-4.1 0/7] Add qemu_getrandom and ARMv8.5-RNG, Daniel P . Berrangé, 2019/03/14
- Re: [Qemu-devel] [PATCH for-4.1 0/7] Add qemu_getrandom and ARMv8.5-RNG, Richard Henderson, 2019/03/14