Re: [Qemu-devel] [PATCH for-4.1 0/7] Add qemu_getrandom and ARMv8.5-RNG

[no-reply]

Patchew URL: https://patchew.org/QEMU/address@hidden/



Hi,

This series seems to have some coding style problems. See output below for
more information:

Type: series
Message-id: address@hidden
Subject: [Qemu-devel] [PATCH for-4.1 0/7] Add qemu_getrandom and ARMv8.5-RNG

=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
 t [tag update]            patchew/address@hidden -> patchew/address@hidden
 t [tag update]            patchew/address@hidden -> patchew/address@hidden
 * [new tag]               patchew/address@hidden -> patchew/address@hidden
Switched to a new branch 'test'
f605897f87 target/arm: Implement ARMv8.5-RNG
bd69ce4cd9 ui/vnc: Use qemu_getrandom for make_challenge
c1324306af linux-user: Remove srand call
cdca1c1a38 linux-user/aarch64: Use qemu_getrandom for arm_init_pauth_key
95ea39c668 linux-user: Use qemu_getrandom for AT_RANDOM
f7e7a71b23 util: Use getrandom for qemu_getrandom if available
11d9c16454 util: Add qemu_getrandom and support functions

=== OUTPUT BEGIN ===
1/7 Checking commit 11d9c16454fc (util: Add qemu_getrandom and support 
functions)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#90: 
new file mode 100644

ERROR: Use g_assert or g_assert_not_reached
#290: FILE: util/random.c:33:
+    g_assert_cmpuint(len, <=, 256);

total: 1 errors, 1 warnings, 284 lines checked

Patch 1/7 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

2/7 Checking commit f7e7a71b2340 (util: Use getrandom for qemu_getrandom if 
available)
ERROR: Use g_assert or g_assert_not_reached
#115: FILE: util/random.c:81:
+    g_assert_cmpuint(len, <=, 256);

ERROR: Use g_assert or g_assert_not_reached
#171: FILE: util/random.c:135:
+    g_assert_cmpint(errno, ==, ENOSYS);

total: 2 errors, 0 warnings, 149 lines checked

Patch 2/7 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

3/7 Checking commit 95ea39c66897 (linux-user: Use qemu_getrandom for AT_RANDOM)
4/7 Checking commit cdca1c1a385b (linux-user/aarch64: Use qemu_getrandom for 
arm_init_pauth_key)
5/7 Checking commit c1324306af95 (linux-user: Remove srand call)
6/7 Checking commit bd69ce4cd97a (ui/vnc: Use qemu_getrandom for make_challenge)
7/7 Checking commit f605897f877f (target/arm: Implement ARMv8.5-RNG)
=== OUTPUT END ===

Test command exited with code: 1


The full log is available at
http://patchew.org/logs/address@hidden/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [http://patchew.org/].
Please send your feedback to address@hidden