[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PULL 17/26] nvdimm: use *function* directly instead of all
From: |
Michael S. Tsirkin |
Subject: |
[Qemu-devel] [PULL 17/26] nvdimm: use *function* directly instead of allocating it again |
Date: |
Tue, 12 Mar 2019 22:55:26 -0400 |
From: Wei Yang <address@hidden>
At the beginning or nvdimm_build_common_dsm(), variable *function* is
already allocated for Arg2.
This patch reuse variable *function* instead of allocating it again.
Signed-off-by: Wei Yang <address@hidden>
Message-Id: <address@hidden>
Reviewed-by: Michael S. Tsirkin <address@hidden>
Signed-off-by: Michael S. Tsirkin <address@hidden>
Reviewed-by: Igor Mammedov <address@hidden>
---
hw/acpi/nvdimm.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/hw/acpi/nvdimm.c b/hw/acpi/nvdimm.c
index 280bfb9d78..3e73ed456f 100644
--- a/hw/acpi/nvdimm.c
+++ b/hw/acpi/nvdimm.c
@@ -1086,7 +1086,7 @@ static void nvdimm_build_common_dsm(Aml *dev)
*/
aml_append(method, aml_store(handle, aml_name(NVDIMM_DSM_HANDLE)));
aml_append(method, aml_store(aml_arg(1), aml_name(NVDIMM_DSM_REVISION)));
- aml_append(method, aml_store(aml_arg(2), aml_name(NVDIMM_DSM_FUNCTION)));
+ aml_append(method, aml_store(function, aml_name(NVDIMM_DSM_FUNCTION)));
/*
* The fourth parameter (Arg3) of _DSM is a package which contains
--
MST
- [Qemu-devel] [PULL 00/26] pci, pc, virtio: features, fixes, cleanups, Michael S. Tsirkin, 2019/03/12
- [Qemu-devel] [PULL 23/26] vhost-user-blk: Add support to get/set inflight buffer, Michael S. Tsirkin, 2019/03/12
- [Qemu-devel] [PULL 26/26] i386, acpi: check acpi_memory_hotplug capacity in pre_plug, Michael S. Tsirkin, 2019/03/12
- [Qemu-devel] [PULL 25/26] gen_pcie_root_port: Add ACS (Access Control Services) capability, Michael S. Tsirkin, 2019/03/12
- [Qemu-devel] [PULL 24/26] pcie: Add a simple PCIe ACS (Access Control Services) helper function, Michael S. Tsirkin, 2019/03/12
- [Qemu-devel] [PULL 21/26] libvhost-user: Introduce vu_queue_map_desc(), Michael S. Tsirkin, 2019/03/12
- [Qemu-devel] [PULL 22/26] libvhost-user: Support tracking inflight I/O in shared memory, Michael S. Tsirkin, 2019/03/12
- [Qemu-devel] [PULL 19/26] vhost-user: Support transferring inflight buffer between qemu and backend, Michael S. Tsirkin, 2019/03/12
- [Qemu-devel] [PULL 20/26] libvhost-user: Remove unnecessary FD flag check for event file descriptors, Michael S. Tsirkin, 2019/03/12
- [Qemu-devel] [PULL 17/26] nvdimm: use *function* directly instead of allocating it again,
Michael S. Tsirkin <=
- [Qemu-devel] [PULL 18/26] nvdimm: use NVDIMM_ACPI_IO_LEN for the proper IO size, Michael S. Tsirkin, 2019/03/12
- [Qemu-devel] [PULL 16/26] nvdimm: fix typo in nvdimm_build_nvdimm_devices argument, Michael S. Tsirkin, 2019/03/12
- Re: [Qemu-devel] [PULL 00/26] pci, pc, virtio: features, fixes, cleanups, Peter Maydell, 2019/03/13