qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH v2 7/7] Makefile: explicitly pass $(BUILD_DIR) t


From: Philippe Mathieu-Daudé
Subject: Re: [Qemu-devel] [PATCH v2 7/7] Makefile: explicitly pass $(BUILD_DIR) to gcovr
Date: Tue, 12 Mar 2019 14:38:49 +0100
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.5.1

On 3/12/19 11:55 AM, Alex Bennée wrote:
> Best to be explicit about where to find things.
> 
> Signed-off-by: Alex Bennée <address@hidden>
> ---
>  Makefile | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/Makefile b/Makefile
> index 7202ac76dc..248fe9db7b 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -964,7 +964,8 @@ $(filter %.1 %.7 %.8,$(DOCS)): scripts/texi2pod.pl
>  %/coverage-report.html:
>       @mkdir -p $*
>       $(call quiet-command,\
> -             gcovr -r $(SRC_PATH) -p --html --html-details -o $@, \
> +             gcovr -r $(SRC_PATH) --object-directory $(BUILD_PATH) \
> +             -p --html --html-details -o $@, \
>               "GEN", "coverage-report.html")
>  
>  .PHONY: coverage-report
> 

Reviewed-by: Philippe Mathieu-Daudé <address@hidden>



reply via email to

[Prev in Thread] Current Thread [Next in Thread]