[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 2/4] block/qcow2-bitmap: Don't check size for
From: |
Eric Blake |
Subject: |
Re: [Qemu-devel] [PATCH v2 2/4] block/qcow2-bitmap: Don't check size for IN_USE bitmap |
Date: |
Mon, 11 Mar 2019 22:09:35 -0500 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.5.1 |
On 3/11/19 1:51 PM, Vladimir Sementsov-Ogievskiy wrote:
> We are going to allow image resize when there are persistent bitmaps.
> It may lead to appearing of inconsistent bitmaps (IN_USE=1) with
> inconsistent size. But we still want to load them as inconsistent.
>
> Signed-off-by: Vladimir Sementsov-Ogievskiy <address@hidden>
> ---
> block/qcow2-bitmap.c | 21 ++++++++++++++++++---
> 1 file changed, 18 insertions(+), 3 deletions(-)
> + {
> + /*
> + * We've loaded valid bitmap (IN_USE not set) or we are going to
> store
> + * valid bitmap. But allocated bitmap table size is not enough to
> store
> + * such bitmap.
> + *
> + * Note, that it's OK to have invalid bitmap with invalid size
> during to
s/during/due/
> + * bitmap was not correctly saved after image resize.
s/bitmap/a bitmap that/
> + */
> + return -EINVAL;
> + }
> +
> + return 0;
> }
>
> static inline void bitmap_directory_to_be(uint8_t *dir, size_t size)
>
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3226
Virtualization: qemu.org | libvirt.org
signature.asc
Description: OpenPGP digital signature
- [Qemu-devel] [PATCH v2 0/4] block/qcow2-bitmap: Enable resize with persistent bitmaps, Vladimir Sementsov-Ogievskiy, 2019/03/11
- [Qemu-devel] [PATCH v2 2/4] block/qcow2-bitmap: Don't check size for IN_USE bitmap, Vladimir Sementsov-Ogievskiy, 2019/03/11
- Re: [Qemu-devel] [PATCH v2 2/4] block/qcow2-bitmap: Don't check size for IN_USE bitmap,
Eric Blake <=
- [Qemu-devel] [PATCH v2 3/4] block/qcow2-bitmap: Allow resizes with persistent bitmaps, Vladimir Sementsov-Ogievskiy, 2019/03/11
- [Qemu-devel] [PATCH v2 4/4] tests/qemu-iotests: add bitmap resize test 246, Vladimir Sementsov-Ogievskiy, 2019/03/11
- [Qemu-devel] [PATCH v2 1/4] docs/interop/qcow2: Improve bitmap flag in_use specification, Vladimir Sementsov-Ogievskiy, 2019/03/11
- Re: [Qemu-devel] [PATCH v2 0/4] block/qcow2-bitmap: Enable resize with persistent bitmaps, John Snow, 2019/03/12