[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH 02/11] target/hppa: fix TLB handling for page 0
From: |
Sven Schnelle |
Subject: |
[Qemu-devel] [PATCH 02/11] target/hppa: fix TLB handling for page 0 |
Date: |
Mon, 11 Mar 2019 20:15:53 +0100 |
Assume the following sequence:
pitlbe r0(sr0,r0)
iitlba r4,(sr0,r0)
ldil L%3000000,r5
iitlbp r5,(sr0,r0)
This will purge the whole TLB and add an entry for page 0. However
the current TLB implementation in helper_iitlba() will store to
the last empty TLB entry, while helper_iitlbp() will write to the
first empty entry. That is because an empty entry will match address
0 in helper_iitlba()
Signed-off-by: Sven Schnelle <address@hidden>
---
target/hppa/mem_helper.c | 14 ++++++++------
1 file changed, 8 insertions(+), 6 deletions(-)
diff --git a/target/hppa/mem_helper.c b/target/hppa/mem_helper.c
index aecf3075f6..f30824f4e1 100644
--- a/target/hppa/mem_helper.c
+++ b/target/hppa/mem_helper.c
@@ -238,15 +238,17 @@ void HELPER(itlba)(CPUHPPAState *env, target_ulong addr,
target_ureg reg)
{
hppa_tlb_entry *empty = NULL;
int i;
-
/* Zap any old entries covering ADDR; notice empty entries on the way. */
for (i = 0; i < ARRAY_SIZE(env->tlb); ++i) {
hppa_tlb_entry *ent = &env->tlb[i];
- if (!ent->entry_valid) {
- empty = ent;
- } else if (ent->va_b <= addr && addr <= ent->va_e) {
- hppa_flush_tlb_ent(env, ent);
- empty = ent;
+ if (ent->va_b <= addr && addr <= ent->va_e) {
+ if (ent->entry_valid) {
+ hppa_flush_tlb_ent(env, ent);
+ }
+
+ if (!empty) {
+ empty = ent;
+ }
}
}
--
2.20.1
- [Qemu-devel] [PATCH 06/11] target/hppa: ignore DIAG opcode, (continued)
- [Qemu-devel] [PATCH 06/11] target/hppa: ignore DIAG opcode, Sven Schnelle, 2019/03/11
- [Qemu-devel] [PATCH 10/11] target/hppa: exit TB if either Data or Instruction TLB changes, Sven Schnelle, 2019/03/11
- [Qemu-devel] [PATCH 07/11] target/hppa: fix b,gate instruction, Sven Schnelle, 2019/03/11
- [Qemu-devel] [PATCH 05/11] target/hppa: remove PSW I/R/Q bit check, Sven Schnelle, 2019/03/11
- [Qemu-devel] [PATCH 01/11] target/hppa: fix overwriting source reg in addb, Sven Schnelle, 2019/03/11
- [Qemu-devel] [PATCH 02/11] target/hppa: fix TLB handling for page 0,
Sven Schnelle <=
- [Qemu-devel] [PATCH 03/11] target/hppa: report ITLB_EXCP_MISS for ITLB misses, Sven Schnelle, 2019/03/11
- [Qemu-devel] [PATCH 04/11] target/hppa: add TLB trace events, Sven Schnelle, 2019/03/11
- [Qemu-devel] [PATCH 08/11] target/hppa: allow multiple itlbp without itlba, Sven Schnelle, 2019/03/11
- Re: [Qemu-devel] [PATCH 00/11] target/hppa patches, no-reply, 2019/03/11
- Re: [Qemu-devel] [PATCH 00/11] target/hppa patches, Richard Henderson, 2019/03/12