[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PULL v2 29/31] qom: cpu: destroy work_mutex in cpu_common_
From: |
Paolo Bonzini |
Subject: |
[Qemu-devel] [PULL v2 29/31] qom: cpu: destroy work_mutex in cpu_common_finalize |
Date: |
Mon, 11 Mar 2019 17:55:33 +0100 |
From: Li Qiang <address@hidden>
Commit 376692b9dc6(cpus: protect work list with work_mutex)
initialize a work_mutex in cpu_common_initfn, however forget
to destroy it. This will cause resource leak when hotunplug cpu
or hotplug cpu fails.
Signed-off-by: Li Qiang <address@hidden>
Message-Id: <address@hidden>
Reviewed-by: Philippe Mathieu-Daudé <address@hidden>
Signed-off-by: Paolo Bonzini <address@hidden>
---
qom/cpu.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/qom/cpu.c b/qom/cpu.c
index f5579b1..a8d2958 100644
--- a/qom/cpu.c
+++ b/qom/cpu.c
@@ -380,6 +380,9 @@ static void cpu_common_initfn(Object *obj)
static void cpu_common_finalize(Object *obj)
{
+ CPUState *cpu = CPU(obj);
+
+ qemu_mutex_destroy(&cpu->work_mutex);
}
static int64_t cpu_common_get_arch_id(CPUState *cpu)
--
1.8.3.1
- [Qemu-devel] [PULL v2 22/31] lsi: use ldn_le_p()/stn_le_p(), (continued)
- [Qemu-devel] [PULL v2 22/31] lsi: use ldn_le_p()/stn_le_p(), Paolo Bonzini, 2019/03/11
- [Qemu-devel] [PULL v2 25/31] lsi: use SCSI phase names instead of numbers in trace, Paolo Bonzini, 2019/03/11
- [Qemu-devel] [PULL v2 20/31] configure: Disable W^X on OpenBSD, Paolo Bonzini, 2019/03/11
- [Qemu-devel] [PULL v2 23/31] lsi: use enum type for s->waiting, Paolo Bonzini, 2019/03/11
- [Qemu-devel] [PULL v2 24/31] lsi: use enum type for s->msg_action, Paolo Bonzini, 2019/03/11
- [Qemu-devel] [PULL v2 26/31] lsi: return dfifo value, Paolo Bonzini, 2019/03/11
- [Qemu-devel] [PULL v2 28/31] exec.c: refactor function flatview_add_to_dispatch(), Paolo Bonzini, 2019/03/11
- [Qemu-devel] [PULL v2 31/31] qemugdb: fix licensing, Paolo Bonzini, 2019/03/11
- [Qemu-devel] [PULL v2 27/31] lsi: 810/895A are always little endian, Paolo Bonzini, 2019/03/11
- [Qemu-devel] [PULL v2 30/31] chardev: add support for authorization for TLS clients, Paolo Bonzini, 2019/03/11
- [Qemu-devel] [PULL v2 29/31] qom: cpu: destroy work_mutex in cpu_common_finalize,
Paolo Bonzini <=
- Re: [Qemu-devel] [PULL v2 00/31] Misc patches for 2019-03-09, Peter Maydell, 2019/03/11