Re: [Qemu-devel] [PATCH v4 10/10] qemu-binfmt-conf.sh: add --test|--dry-run

[Unai Martinez Corral]

2019/3/11 11:45, Laurent Vivier:
> >  while true ; do
> >      case "$1" in
> > +    -t|--test|--dry-run)
>
> We don't need multiple parameter for the same effect. You must choose
> between --test and --dry-run.

Ok. I'll take 'test', because the short for '--dry-run' would be '-d'
and it is already used for 'debian'.

> > +if [ "x$QEMU_TEST" = "xyes" ] ; then
> > +    skip(){
> > +    :;}
> > +    BINFMT_SET=skip
>
> Why do you need a function?
> Can't you set directly BINFMT_SET to ':'?

Indeed...

Regards,
Unai