Re: [Qemu-devel] [PATCH 00/10] bundle edk2 platform firmware with QEMU

[Daniel P . Berrangé]

On Sat, Mar 09, 2019 at 02:10:17PM +0100, Michal Prívozník wrote:
> On 3/9/19 1:48 AM, Laszlo Ersek wrote:
> > Repo:   https://github.com/lersek/qemu.git
> > Branch: edk2_build
> > 
> > This series advances the roms/edk2 submodule to the "edk2-stable201903"
> > release, and builds and captures platform firmware binaries from that
> > release. At this point they are meant to be used by both end-users and
> > by Igor's ACPI unit tests in qtest ("make check").
> > 
> > Previous discussion:
> > 
> >   [Qemu-devel] bundling edk2 platform firmware images with QEMU
> >   http://mid.mail-archive.com/address@hidden
> >   https://lists.gnu.org/archive/html/qemu-devel/2019-03/msg02601.html
> > 
> > Note that the series was formatted with "--no-binary" (affecting patch
> > #8), therefore it cannot be applied with "git-am". See the remote
> > repo/branch reference near the top instead.
> > 
> > Thanks,
> > Laszlo
> > 
> > Laszlo Ersek (10):
> >   roms: lift "edk2-funcs.sh" from "tests/uefi-test-tools/build.sh"
> >   roms/edk2-funcs.sh: require gcc-4.8+ for building i386 and x86_64
> >   tests/uefi-test-tools/build.sh: work around TianoCore#1607
> >   roms/edk2: advance to tag edk2-stable201903
> >   roms/edk2-funcs.sh: add the qemu_edk2_get_thread_count() function
> >   roms/Makefile: replace the $(EFIROM) target with "edk2-basetools"
> >   roms: build edk2 firmware binaries and variable store templates
> >   pc-bios: add edk2 firmware binaries and variable store templates
> >   pc-bios: document the edk2 firmware images; add firmware descriptors
> >   Makefile: install the edk2 firmware images and their descriptors
> > 
> >  Makefile                                       |  17 +-
> >  pc-bios/README                                 |  11 +
> >  pc-bios/descriptors/50-edk2-i386-secure.json   |  34 +++
> >  pc-bios/descriptors/50-edk2-x86_64-secure.json |  35 +++
> >  pc-bios/descriptors/60-edk2-aarch64.json       |  31 +++
> >  pc-bios/descriptors/60-edk2-arm.json           |  31 +++
> >  pc-bios/descriptors/60-edk2-i386.json          |  33 +++
> >  pc-bios/descriptors/60-edk2-x86_64.json        |  34 +++
> >  pc-bios/edk2-aarch64-code.fd                   | Bin 0 -> 67108864 bytes
> >  pc-bios/edk2-arm-code.fd                       | Bin 0 -> 67108864 bytes
> >  pc-bios/edk2-arm-vars.fd                       | Bin 0 -> 67108864 bytes
> >  pc-bios/edk2-i386-code.fd                      | Bin 0 -> 3653632 bytes
> >  pc-bios/edk2-i386-secure-code.fd               | Bin 0 -> 3653632 bytes
> >  pc-bios/edk2-i386-vars.fd                      | Bin 0 -> 540672 bytes
> >  pc-bios/edk2-licenses.txt                      | 209 ++++++++++++++++
> >  pc-bios/edk2-x86_64-code.fd                    | Bin 0 -> 3653632 bytes
> >  pc-bios/edk2-x86_64-secure-code.fd             | Bin 0 -> 3653632 bytes
> >  roms/Makefile                                  |   9 +-
> >  roms/Makefile.edk2                             | 138 +++++++++++
> >  roms/edk2                                      |   2 +-
> >  roms/edk2-build.sh                             |  55 +++++
> >  roms/edk2-funcs.sh                             | 253 ++++++++++++++++++++
> >  tests/uefi-test-tools/build.sh                 | 100 +-------
> >  23 files changed, 897 insertions(+), 95 deletions(-)
> >  create mode 100644 pc-bios/descriptors/50-edk2-i386-secure.json
> >  create mode 100644 pc-bios/descriptors/50-edk2-x86_64-secure.json
> >  create mode 100644 pc-bios/descriptors/60-edk2-aarch64.json
> >  create mode 100644 pc-bios/descriptors/60-edk2-arm.json
> >  create mode 100644 pc-bios/descriptors/60-edk2-i386.json
> >  create mode 100644 pc-bios/descriptors/60-edk2-x86_64.json
> >  create mode 100644 pc-bios/edk2-aarch64-code.fd
> >  create mode 100644 pc-bios/edk2-arm-code.fd
> >  create mode 100644 pc-bios/edk2-arm-vars.fd
> >  create mode 100644 pc-bios/edk2-i386-code.fd
> >  create mode 100644 pc-bios/edk2-i386-secure-code.fd
> >  create mode 100644 pc-bios/edk2-i386-vars.fd
> >  create mode 100644 pc-bios/edk2-licenses.txt
> >  create mode 100644 pc-bios/edk2-x86_64-code.fd
> >  create mode 100644 pc-bios/edk2-x86_64-secure-code.fd
> >  create mode 100644 roms/Makefile.edk2
> >  create mode 100755 roms/edk2-build.sh
> >  create mode 100644 roms/edk2-funcs.sh
> > 
> 
> Unsure whether my ACK is worth anything on this list, but you have it.
>
> Reviewed-by: Michal Privoznik <address@hidden>

Anyone on the QEMU mailing list is welcome, and indeed encouraged to
review patches & add R-b acks if they feel comfortable with the code
they are looking at. As with most projects, QEMU suffers from a
not having enough reviewers to look at the volume of patches sent....

Regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|