Re: [Qemu-devel] [PATCH 3/9] tcg: Use extract2 in tcg_gen_shifti_i64

[Richard Henderson]

On 3/9/19 12:30 PM, Aleksandar Markovic wrote:
> 
> 
> On Thursday, March 7, 2019, Richard Henderson <address@hidden
> <mailto:address@hidden>> wrote:
> 
>     Signed-off-by: Richard Henderson <address@hidden
>     <mailto:address@hidden>>
>     ---
>      tcg/tcg-op.c | 47 ++++++++++++++++++++++++-----------------------
>      1 file changed, 24 insertions(+), 23 deletions(-)
> 
> 
> Extract2 is not a good name for this new function, IMHO.

If you're going to bike shed the name, you should suggest something else.

But I think it's a pretty good name, since it extracts one register output out
of two register inputs.


r~