[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 12/12] docs/interop/firmware.json: Prefer -ma
From: |
Laszlo Ersek |
Subject: |
Re: [Qemu-devel] [PATCH v2 12/12] docs/interop/firmware.json: Prefer -machine to if=pflash |
Date: |
Fri, 8 Mar 2019 09:44:27 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 |
On 03/07/19 18:24, Markus Armbruster wrote:
> The previous commit added a way to configure firmware with -blockdev
> rather than -drive if=pflash. Document it as the preferred way.
>
> Signed-off-by: Markus Armbruster <address@hidden>
> ---
> docs/interop/firmware.json | 21 +++++++++++++++------
> 1 file changed, 15 insertions(+), 6 deletions(-)
>
> diff --git a/docs/interop/firmware.json b/docs/interop/firmware.json
> index 28f9bc1591..db3cb38b6a 100644
> --- a/docs/interop/firmware.json
> +++ b/docs/interop/firmware.json
> @@ -212,9 +212,13 @@
> #
> # @executable: Identifies the firmware executable. The firmware
> # executable may be shared by multiple virtual machine
> -# definitions. The corresponding QEMU command line option
> -# is "-drive
> -#
> if=pflash,unit=0,readonly=on,address@hidden@filename,address@hidden@format".
> +# definitions. The preferred corresponding QEMU command
> +# line option is
> +# -drive
> if=none,id=pflash0,readonly=on,address@hidden@filename,address@hidden@format
> +# -machine pflash0=pflash0
> +# or equivalent -blockdev.
If we used plural here ("options"), would that be an improvement?
The preferred corresponding QEMU command line options are
-drive ...
-machine ...
(or -blockdev equivalent to -drive).
> +# With QEMU versions older than 4.0, you have to use
To make this easier to understand on first read, should we say
... you have to use the single option ...
?
(Maybe there is a better term than "single option" for the "-drive
if=<not-NONE>" options, i.e. for those that configure both back-end and
front-end.)
If the above over-explained things, I'd be fine with the current patch as well.
I just got these ideas and wanted to run them by you.
Thanks!
Laszlo
> +# -drive
> if=pflash,unit=0,readonly=on,address@hidden@filename,address@hidden@format
> #
> # @nvram-template: Identifies the NVRAM template compatible with
> # @executable. Management software instantiates an
> @@ -225,9 +229,14 @@
> # individual copies of it are. An NVRAM file is
> # typically used for persistently storing the
> # non-volatile UEFI variables of a virtual machine
> -# definition. The corresponding QEMU command line
> -# option is "-drive
> -#
> if=pflash,unit=1,readonly=off,file=FILENAME_OF_PRIVATE_NVRAM_FILE,address@hidden@format".
> +# definition. The preferred corresponding QEMU
> +# command line option is
> +# -drive
> if=none,id=pflash1,readonly=off,file=FILENAME_OF_PRIVATE_NVRAM_FILE,address@hidden@format
> +# -machine pflash1=pflash1
> +# or equivalent -blockdev.
> +# With QEMU versions older than 4.0, you have to use
> +# -drive
> if=pflash,unit=1,readonly=off,file=FILENAME_OF_PRIVATE_NVRAM_FILE,address@hidden@format
> +#
> #
> # Since: 3.0
> ##
>
- Re: [Qemu-devel] [PATCH v2 06/12] vl: Factor configure_blockdev() out of main(), (continued)
[Qemu-devel] [PATCH v2 11/12] pc: Support firmware configuration with -blockdev, Markus Armbruster, 2019/03/07
[Qemu-devel] [PATCH v2 10/12] pc_sysfw: Pass PCMachineState to pc_system_firmware_init(), Markus Armbruster, 2019/03/07
[Qemu-devel] [PATCH v2 12/12] docs/interop/firmware.json: Prefer -machine to if=pflash, Markus Armbruster, 2019/03/07
- Re: [Qemu-devel] [PATCH v2 12/12] docs/interop/firmware.json: Prefer -machine to if=pflash,
Laszlo Ersek <=
[Qemu-devel] [PATCH v2 05/12] vl: Improve legibility of BlockdevOptions queue, Markus Armbruster, 2019/03/07
[Qemu-devel] [PATCH v2 08/12] pflash_cfi01: Add pflash_cfi01_get_blk() helper, Markus Armbruster, 2019/03/07
[Qemu-devel] [PATCH v2 07/12] vl: Create block backends before setting machine properties, Markus Armbruster, 2019/03/07
[Qemu-devel] [PATCH v2 09/12] pc_sysfw: Remove unused PcSysFwDevice, Markus Armbruster, 2019/03/07
Re: [Qemu-devel] [PATCH v2 00/12] pc: Support firmware configuration with -blockdev, no-reply, 2019/03/07
Re: [Qemu-devel] [PATCH v2 00/12] pc: Support firmware configuration with -blockdev, no-reply, 2019/03/07
Re: [Qemu-devel] [PATCH v2 00/12] pc: Support firmware configuration with -blockdev, no-reply, 2019/03/07
Re: [Qemu-devel] [PATCH v2 00/12] pc: Support firmware configuration with -blockdev, no-reply, 2019/03/08