Re: [Qemu-devel] [PATCH v2 00/12] pc: Support firmware configuration with -blockdev

[no-reply]

Patchew URL: https://patchew.org/QEMU/address@hidden/



Hi,

This series seems to have some coding style problems. See output below for
more information:

Type: series
Message-id: address@hidden
Subject: [Qemu-devel] [PATCH v2 00/12] pc: Support firmware configuration with 
-blockdev

=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
 t [tag update]            patchew/address@hidden -> patchew/address@hidden
Switched to a new branch 'test'
3ea929de65 docs/interop/firmware.json: Prefer -machine to if=pflash
b2f120dc53 pc: Support firmware configuration with -blockdev
e20c52727e pc_sysfw: Pass PCMachineState to pc_system_firmware_init()
d51f290e9e pc_sysfw: Remove unused PcSysFwDevice
96565445f8 pflash_cfi01: Add pflash_cfi01_get_blk() helper
bb44a08024 vl: Create block backends before setting machine properties
3806557e1f vl: Factor configure_blockdev() out of main()
984f18284e vl: Improve legibility of BlockdevOptions queue
ee5d063c25 sysbus: Fix latent bug with onboard devices
1e5f89d716 vl: Fix latent bug with -global and onboard devices
19954ff0fa qom: Move compat_props machinery from qdev to QOM
27f1c4f184 qdev: Fix latent bug with compat_props and onboard devices

=== OUTPUT BEGIN ===
1/12 Checking commit 27f1c4f18410 (qdev: Fix latent bug with compat_props and 
onboard devices)
2/12 Checking commit 19954ff0fa94 (qom: Move compat_props machinery from qdev 
to QOM)
3/12 Checking commit 1e5f89d716e8 (vl: Fix latent bug with -global and onboard 
devices)
4/12 Checking commit ee5d063c25a6 (sysbus: Fix latent bug with onboard devices)
5/12 Checking commit 984f18284e05 (vl: Improve legibility of BlockdevOptions 
queue)
6/12 Checking commit 3806557e1f00 (vl: Factor configure_blockdev() out of 
main())
WARNING: Block comments use a leading /* on a separate line
#26: FILE: vl.c:1207:
+    /* If the currently selected machine wishes to override the units-per-bus

WARNING: Block comments use a trailing */ on a separate line
#27: FILE: vl.c:1208:
+     * property of its default HBA interface type, do so now. */

total: 0 errors, 2 warnings, 83 lines checked

Patch 6/12 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
7/12 Checking commit bb44a0802451 (vl: Create block backends before setting 
machine properties)
8/12 Checking commit 96565445f821 (pflash_cfi01: Add pflash_cfi01_get_blk() 
helper)
9/12 Checking commit d51f290e9e75 (pc_sysfw: Remove unused PcSysFwDevice)
10/12 Checking commit e20c52727e5d (pc_sysfw: Pass PCMachineState to 
pc_system_firmware_init())
11/12 Checking commit b2f120dc5319 (pc: Support firmware configuration with 
-blockdev)
WARNING: line over 80 characters
#373: FILE: hw/i386/pc_sysfw.c:328:
+            error_report("pflash with kvm requires KVM readonly memory 
support");

total: 0 errors, 1 warnings, 315 lines checked

Patch 11/12 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
12/12 Checking commit 3ea929de6531 (docs/interop/firmware.json: Prefer -machine 
to if=pflash)
ERROR: trailing whitespace
#49: FILE: docs/interop/firmware.json:239:
+#                  $

total: 1 errors, 0 warnings, 33 lines checked

Patch 12/12 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

=== OUTPUT END ===

Test command exited with code: 1


The full log is available at
http://patchew.org/logs/address@hidden/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [http://patchew.org/].
Please send your feedback to address@hidden