[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH v2 05/18] hw/nvram/fw_cfg: Use the ldst API
From: |
Philippe Mathieu-Daudé |
Subject: |
[Qemu-devel] [PATCH v2 05/18] hw/nvram/fw_cfg: Use the ldst API |
Date: |
Fri, 8 Mar 2019 02:32:09 +0100 |
The load/store API eases code review.
Signed-off-by: Philippe Mathieu-Daudé <address@hidden>
---
hw/nvram/fw_cfg.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/hw/nvram/fw_cfg.c b/hw/nvram/fw_cfg.c
index 684c2cf00a..8eb76a382c 100644
--- a/hw/nvram/fw_cfg.c
+++ b/hw/nvram/fw_cfg.c
@@ -141,7 +141,7 @@ static char *read_splashfile(char *filename, gsize
*file_sizep,
}
/* check magic ID */
- filehead = ((content[0] & 0xff) + (content[1] << 8)) & 0xffff;
+ filehead = lduw_le_p(content);
if (filehead == 0xd8ff) {
file_type = JPG_FILE;
} else if (filehead == 0x4d42) {
@@ -152,7 +152,7 @@ static char *read_splashfile(char *filename, gsize
*file_sizep,
/* check BMP bpp */
if (file_type == BMP_FILE) {
- bmp_bpp = (content[28] + (content[29] << 8)) & 0xffff;
+ bmp_bpp = lduw_le_p(&content[28]);
if (bmp_bpp != 24) {
goto error;
}
--
2.20.1
- Re: [Qemu-devel] [PATCH v2 02/18] hw/i386: Remove unused include, (continued)
- [Qemu-devel] [PATCH v2 04/18] hw/nvram/fw_cfg: Add trace events, Philippe Mathieu-Daudé, 2019/03/07
- [Qemu-devel] [PATCH v2 05/18] hw/nvram/fw_cfg: Use the ldst API,
Philippe Mathieu-Daudé <=
- [Qemu-devel] [PATCH v2 06/18] hw/nvram/fw_cfg: Remove the unnecessary boot_splash_filedata_size, Philippe Mathieu-Daudé, 2019/03/07
- [Qemu-devel] [PATCH v2 07/18] hw/nvram/fw_cfg: Add fw_cfg_common_unrealize(), Philippe Mathieu-Daudé, 2019/03/07
- Re: [Qemu-devel] [PATCH v2 07/18] hw/nvram/fw_cfg: Add fw_cfg_common_unrealize(), Markus Armbruster, 2019/03/09