Re: [Qemu-devel] [multiprocess RFC PATCH 22/37] multi-process: QMP/HMP commands to remove device from the remote process

[Eric Blake]

On 3/7/19 1:22 AM, address@hidden wrote:
> From: Jagannathan Raman <address@hidden>
> 
> Add rdevice_del QMP & HMP commands to hot-unplug device from remote
> device.
> 
> Signed-off-by: Jagannathan Raman <address@hidden>
> Signed-off-by: John G Johnson <address@hidden>
> Signed-off-by: Elena Ufimtseva <address@hidden>
> ---

Similar to my other mail (it will probably get hard to track whether
I've replied everywhere or in order, thanks to the threading, but I see
that's already been mentioned):


> +++ b/qapi/misc.json
> @@ -1717,6 +1717,33 @@
>  { 'command': 'device_del', 'data': {'id': 'str'} }
>  
>  ##
> +# @rdevice_del:
> +#

New QMP commands should favor '-' over '_'; if we add it at all, it
should be 'rdevice-del'.

> +# Remove a device from a guest
> +#
> +# @rdev_id: ID of the remote device root
> +#
> +# @id: the device's ID
> +#
> +# Returns: Nothing on success
> +#          If @id is not a valid device, DeviceNotFound
> +#
> +# Notes: When this command completes, the device may not be removed from the
> +#        guest.  Hot removal is an operation that requires guest cooperation.
> +#        This command merely requests that the guest begin the hot removal
> +#        process.  Completion of the device removal process is signaled with 
> a
> +#        DEVICE_DELETED event. Guest reset will automatically complete 
> removal
> +#        for all devices.
> +#
> +# Since: 3.0

and the soonest you're likely to get this in is 4.1.

-- 
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3226
Virtualization:  qemu.org | libvirt.org

signature.asc
Description: OpenPGP digital signature