|
From: | Jason J. Herne |
Subject: | Re: [Qemu-devel] [PATCH v3 13/16] s390-bios: Use control unit type to determine boot method |
Date: | Thu, 7 Mar 2019 11:27:48 -0500 |
User-agent: | Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.2.1 |
On 3/5/19 7:27 AM, Cornelia Huck wrote:
On Fri, 1 Mar 2019 13:59:33 -0500 "Jason J. Herne" <address@hidden> wrote:The boot method is different depending on which device type we are booting from. Let's examine the control unit type to determine if we're a virtio device. We'll eventually add a case to check for a real dasd device here as well. Since we have to call enable_subchannel() in main now, might as well remove that call from virtio.c : run_ccw().Any reason you cannot add the enable_subchannel() in the previous patch? Then you never need to introduce it in run_ccw() :)
Just for clarity, the enablement of the subchannel has always been done in run_ccw. I merely encapsulated the logic into a function in patch #7. I do end up removing it here in #13, but this will actually break the netboot case I pointed out in my previous reply. I agree that we can remove the call to enable_subchannel here if we add it to find_net_dev() but it is not a matter of never having introduced it in the first place.
-- -- Jason J. Herne (address@hidden)
[Prev in Thread] | Current Thread | [Next in Thread] |